Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a JS error happens a lot of empty blocks are created #1

Open
brenes opened this issue Nov 12, 2014 · 0 comments
Open

When a JS error happens a lot of empty blocks are created #1

brenes opened this issue Nov 12, 2014 · 0 comments
Assignees
@brenes
Labels
bug

Comments

@brenes
Copy link
Member

brenes commented Nov 12, 2014

This happens because all the "template" blocks used by the NoCms.Admin.BlockHandler are not detached and are sent when sending the form.

We have to mark those blocks as "tentative" or something that prevents them to be created.
@brenes brenes added the bug label Nov 12, 2014
@brenes brenes self-assigned this Nov 12, 2014
brenes added a commit that referenced this issue Nov 13, 2014
@brenes
#1 Decorating NoCms::Pages::Block model so we create a custom attrib…
0f17b1c 
…ute for marking a block as a template
brenes added a commit that referenced this issue Nov 13, 2014
@brenes
#1 Loading the template blocks as templates
25f1355
brenes added a commit that referenced this issue Nov 13, 2014
@brenes
#1 When a block is marked as a template the _destroy field is set to 1.
971cf0d 
This way the block will be destroyed and not stored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brenes brenes

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brenes