Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation option #32

Closed
ghost opened this issue Jan 1, 2017 · 3 comments
Closed

Rotation option #32

ghost opened this issue Jan 1, 2017 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 1, 2017

Please, add an ability to rotate the image;

Or, in alternative, change the position of the color box (for example on the bar)

@Lonami
Copy link
Contributor

Lonami commented Jan 9, 2017

I just implemented this but the drawing doesn't rotate itself, but rather you can rotate the screen. Let me show you:

eh

(Sorry for the huge .gif) — I made use of this to save maps into a parcelable, this to save the state of the canvas and this (comment) to make the Path serializable. Should I make a PR yet, or am I missing something?

Edit: Note that if you have the "Save" dialog open and you rotate the screen, it vanishes, but this also sort of obvious because it now is different to save in portrait or in landscape mode.

Edit 2: I found this neat trick to keep the dialog accross orientation changes. Without it, the dialog leaks.

@tibbi
Copy link
Member

tibbi commented Jan 9, 2017

well if theres not too many changes, you can try creating some PR. Dont care about the disappearing dialog, I usually dont care about rotations at all. It just doesnt happen that often to waste too much time on it.

@Lonami
Copy link
Contributor

Lonami commented Jan 9, 2017

well if theres not too many changes, you can try creating some PR

Okay awesome!

I usually dont care about rotations at all

Neither did I until some of my users found out that some rotation changes involved data loss… I always use the phone in portrait, but the rotation change may happen accidentally! I'll remove that part from the code though.

@tibbi tibbi closed this as completed in 55c0fea Jan 14, 2017
tibbi added a commit that referenced this issue Jan 14, 2017
Add ability to rotate the canvas (closes #32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants