Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

direct call widget not working #67

Closed
fsegatoz opened this issue May 23, 2023 · 6 comments · Fixed by #92
Closed

direct call widget not working #67

fsegatoz opened this issue May 23, 2023 · 6 comments · Fixed by #92
Labels
bug

Comments

@fsegatoz
Copy link

Hi all, I'm using Simple Launcher 5.0.6 in a Fairphone FP3+ with Android 11 (last updated April 5 2023).
In my home screen, I've created a widget for direct calling one of my contacts.
When I tap the widget to call, I get the following error:
Error: java.lang.SecurityException: Permission Denial: starting Intent { act=android.intent.action.CALL dat=tel:xxxxxxxxxxxxxxxx flg=0x4000000 cmp=com.android.server.telecom/components.UserCallActivity (has extras) } from ProcessRecord{dfda0b3024:com.simplemobiletools.launcher/u0a263} (pid=3824, UID=10263) requires android.permission.CALL_PHONE
I've checked under app permissions, but I see no missing permissions for Simple Laucher.
@tibbi
Copy link
Member

tibbi commented May 23, 2023

Hi, does calling from the app settings work well?

@fsegatoz
Copy link
Author

fsegatoz commented May 23, 2023 via email

@tibbi
Copy link
Member

tibbi commented May 23, 2023

I mean calling from our app itself, not sure why I mentioned the app settings..

@fsegatoz
Copy link
Author

fsegatoz commented May 23, 2023 via email

@tibbi
Copy link
Member

tibbi commented May 23, 2023

how was the misbehaving widget created? It belongs to Google Phone and not our dialer?

@fsegatoz
Copy link
Author

fsegatoz commented May 23, 2023 via email

@tibbi tibbi added the bug label May 23, 2023
esensar referenced this issue in esensar/Simple-Launcher Jul 26, 2023
@esensar
Store all shortcuts with IDs without Intent
befd1d5 
This handles all shortcuts the same, using the recommended mechanism
of using `LauncherApps` to get `PinItemRequest` from result intent.
This makes `intent` field obsolete.

This closes #67
@esensar esensar mentioned this issue Jul 26, 2023
Merged
@tibbi tibbi closed this as completed in #92 Jul 26, 2023
esensar referenced this issue in esensar/Simple-Launcher Jul 26, 2023
@esensar
Add migration for changes made to shortcuts
0b497a3 
Since #67 was fixed in #92, `intent` field in `HomeScreenGridItem`
became obsolete. This removes that field and properly migrates it,
by adding this to existing version 4 to 5 migration (meaning this
will only properly migrate between real releases). The migration will
also remove all icons that had `intent` field populated, since they
can't be migrated properly and would not work at all.
@esensar esensar mentioned this issue Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store all shortcuts with IDs without Intent esensar/Simple-Launcher
2 participants
@tibbi @fsegatoz