-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow Keys jump to URLs and do not move cursor #621
Comments
Im pretty sure that is the expected behaviour. Anyway, such things are handled by the system, not us. |
I wouldn't call that expected behavior. If I'm inserting text & having a blinking "text" cursor, I'm expecting that my arrow keys do move the "text" cursor & not jump in between elements. However, I found out the exact conditions the issue is appearing (tested with version 6.15.5):
This is a screen record where I reproduce the issue: _screencapture.mp4I have no real experience in Android development specific, but to me it looks like the focus isn't correctly set to be only on the text input after the link was selected once. I cannot say if this might be an issue with the Android system, but this is the only app where I experience this. Anyway, I will keep my eyes open to find an app with a similar simple text UI & link recognizing to see if it experiences the same error. |
that is all done by the system, not us. |
- fixes SimpleMobileTools#621 - hotfix causing the issue implemented in 1741070
Sorry, I value the huge work you put in this app, but I disagree with you. I've looked in-depth into the code & I found out the hotfix added in 1741070 is causing that, with "Make links and emails clickable" enabled, the fix you introduced in 696858e for #136 is reverted at runtime in the case I presented above. Your fix for #136 wants to use Simple-Notes/app/src/main/kotlin/com/simplemobiletools/notes/pro/fragments/TextFragment.kt Lines 55 to 61 in 148c9e5
And it does in my case, after a fresh launch, the arrow keys work fine. But when selecting a text, this hotfix comes in to solve an issue in Android <=6 Google "couldn't" fix by enabling Simple-Notes/app/src/main/kotlin/com/simplemobiletools/notes/pro/activities/MainActivity.kt Lines 256 to 258 in 148c9e5
So I concluded that changing line 257 to use Alternatively, or rather additionally, the hotfix may be guarded to be only applied on Android <=6 devices (like proposed here), to avoid further hassle with this workaround where it is not needed, as it feels kind of "hacky" and hopefully is only required on such old Android versions (However, that requires further testing with older devices at least I cannot do, that's why I didn't add this to my PR). |
This might be a regression of #136 & #178 solved by commit 696858e.
I use LineageOS+microG and AnySoftKeyboard. Using the arrow buttons of AnySoftKeyboard or the feature of LineageOS to use the hardware volume keys as arrow keys do jump between the URLs available and do not move to cursor as expected.
App Version: 6.15.4 (at time of writing, the newest)
LineageOS Version: 20-20230410-microG-FP4
The text was updated successfully, but these errors were encountered: