[BUG] Redis options not set - default to expire 0

[greg606]

Description

When using Redis Cache there is no way to set redis cache expiry.
Url params are not taken into account

Steps to Reproduce

Steps to reproduce the behavior:

$remoteFeed = new SimplePie();
$remoteFeed->set_cache_location('redis://localhost:6379/?timeout=3600&prefix=sp_&dbIndex=0');
$remoteFeed->set_cache_duration(3601);
$remoteFeed->set_feed_url('any url');
$remoteFeed->init();

Expected Behavior

TTL of redis key not -1

Actual Behavior

TTL of redis key is -1

Possible Solutions

simplepie/library/SimplePie/Cache/Redis.php

Line 63 in 11ddaed

public function __construct($location, $name, $options = null) {

is always null
also constructor has wrong phpdoc

Environment

dev-master
php-redis on linux mint, php 7.3

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[AnTheMaker]

This still isn't fixed yet, is it? I'm running into the same bug...

[AnTheMaker]

Made a PR to fix this bug, hope it gets merged!

[Art4]

With SimplePie 1.8.0 it will be possible to set Redis as a PSR-16 cache implementation and modify there the cache expiry.