Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Parse error on PHP versions < 5.6 #624

Closed
prbt2016 opened this issue Sep 23, 2019 · 2 comments
Closed

[BUG] Parse error on PHP versions < 5.6 #624

prbt2016 opened this issue Sep 23, 2019 · 2 comments
Assignees
Labels

Comments

@prbt2016
Copy link

Description

After successful setup of SimplePie version 1.5.3(downloaded using git clone) on PHP 5.3.29, I encountered with the following Parse error i.e

Parse error: syntax error, unexpected '*' in /{{path}}/{{to}}/{{simplepie}}/library/SimplePie/Parse/Date.php on line 727

Steps to Reproduce

Steps to reproduce the behavior:

  1. Try to add any valid RSS feed URL or visit any of the given RSS feed URL's .
  2. After visiting you will get the above error if PHP version is less than 5.6 and RSS feed wont be loaded.

Environment

SimplePie version - 1.5.3
PHP version - 5.3.29
Apache version -2.2.34
O.S - Centos 6.4 Final

####Cause
On line 127 is the following code i.e $second = round((int)$match[6] + (int)$match[7] / (10 ** strlen($match[7]))); . The symbol '**' is supported since PHP 5.6.0 and minimum mentioned requirement here :
https://github.com/simplepie/simplepie is 5.3.0+.

Has the script requirement changed to PHP 5.6 or could you please fix this by adding a fix for PHP versions less than 5.6 by using pow() function that was used earlier ?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.89. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the bug label Sep 23, 2019
@mblaney
Copy link
Member

mblaney commented Sep 24, 2019

thanks @prbt2016 SimplePie now requires PHP 5.6 or newer.

@mblaney mblaney closed this as completed Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants