Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PHP Notices #353

Merged
merged 3 commits into from
Mar 13, 2016
Merged

Remove PHP Notices #353

merged 3 commits into from
Mar 13, 2016

Conversation

blat
Copy link
Contributor

@blat blat commented Feb 28, 2014

Example:

$feed = new SimplePie();
$feed->set_feed_url('http://feeds.feedburner.com/surfline-rss-surf-news');
$feed->init();
foreach ($feed->get_items() as $item) {
    $item->get_gmdate();
}

Result:

PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723
PHP Notice:  Uninitialized string offset: -1 in /simplepie/library/SimplePie/Parse/Date.php on line 723

This is due to invalid pub data in RSS.
Format is (MM/dd).

Another example:

$feed = new SimplePie();
$feed->set_feed_url('http://www.express.pk/feed/');
$feed->init();
foreach ($feed->get_items() as $item) {
    $item->get_enclosures();
}

Result:

PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736
PHP Notice:  Undefined index: url in /simplepie/library/SimplePie/Item.php on line 2736

Another example:

$feed = new SimplePie();
$feed->set_feed_url('http://data.msnbc.msn.com/feeds/franchise/foodmain?output=mrss');
$feed->init();
foreach ($feed->get_items() as $item) {
    $item->get_enclosures();
}

Result:

PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661
PHP Notice:  Undefined index: in /simplepie/library/SimplePie/Item.php on line 2661

@lexaurin
Copy link
Contributor

lexaurin commented Jun 9, 2014

+1

@blat blat changed the title PHP Notice when a date starts with '(' Remove PHP Notices Sep 29, 2014
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Jul 11, 2015
@Alkarex
Merge some pull requests from upstream
cb114a3 
silent Warning cast with PHP 5.3.3 (RHEL-6)
simplepie/simplepie#258
Use rss:pubDate over atom:updated when determining the posting date
simplepie/simplepie#288
Update Item.php: add support for media thumbnails
simplepie/simplepie#340
Remove PHP Notices simplepie/simplepie#353
And removed "FreshRSS" annotations for pull requests submitted upstream

Fixed a typo in Date.php (wrong number for September)
simplepie/simplepie#374
Remove duplicate case simplepie/simplepie#406
Added set_curl_options method to allow custom options
simplepie/simplepie#407
Improved error message simplepie/simplepie#412
@Alkarex Alkarex mentioned this pull request Jul 11, 2015
Merged
mblaney added a commit that referenced this pull request Mar 13, 2016
@mblaney
Merge pull request #353 from blat/master
00472b0 
Remove PHP Notices
@mblaney mblaney merged commit 00472b0 into simplepie:master Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blat @lexaurin @mblaney