Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 5.2 is not supported anymore #469

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Conversation

Alkarex
Copy link
Contributor

@Alkarex Alkarex commented Aug 28, 2016

Patches such as #388 and a6e19f1 killed PHP 5.2 without updating the documentation and version checks.
So the documentation and the code still allowed PHP 5.2, but SimplePie 1.4+ does not support it any more:

Warning: Unexpected character in input:  '\' (ASCII=92) state=1 in ./simplepie/library/SimplePie/ on line 460

Parse error: syntax error, unexpected T_STRING in ./simplepie/library/SimplePie/Parser.php on line 460

The Web site should be updated as well http://simplepie.org/wiki/setup/requirements

Patches such as simplepie#388 and
simplepie@a6e19f1
killed PHP 5.2 without updating the documentation and version checks.
So the documentation and the code still allowed PHP 5.2, but SimplePie
1.4+ does not support it any more:

```
Warning: Unexpected character in input:  '\' (ASCII=92) state=1 in
./simplepie/library/SimplePie/ on line 460

Parse error: syntax error, unexpected T_STRING in
./simplepie/library/SimplePie/Parser.php on line 460
```

The Web site should be updated as well
http://simplepie.org/wiki/setup/requirements
@Alkarex
Copy link
Contributor Author

Alkarex commented Aug 28, 2016

Where is this commit gone? eb08fa1

@Alkarex
Copy link
Contributor Author

Alkarex commented Aug 28, 2016

This merged pull request also seems to have been reverted somewhere #388

@mblaney mblaney merged commit 15e42dd into simplepie:master Aug 29, 2016
@mblaney
Copy link
Member

mblaney commented Aug 29, 2016

thanks @Alkarex, and nice to hear from you again. It looks like the README update from #388 got reverted somewhere, but the rest of the changes are still there or have been superseded. Same with eb08fa1.

@Alkarex Alkarex deleted the remove-php5.2 branch August 29, 2016 06:50
@Alkarex
Copy link
Contributor Author

Alkarex commented Aug 29, 2016

@mblaney I cannot see in the history an explicit, voluntary, change that overwrites #388 and eb08fa1.
See e.g. https://github.com/simplepie/simplepie/commits/master/library/SimplePie/Sanitize.php and compare with https://github.com/wikidi/simplepie/commits/649102f6b5e0175f11e23447863a577edd7fc18d/library/SimplePie/Sanitize.php
It looks like by some changes have been erased by git manipulation, which makes it difficult to find out whether it was voluntarily or not.
Follow-up in #388 (comment)

@mblaney
Copy link
Member

mblaney commented Aug 29, 2016

I agree @Alkarex, it was not explicit but progressive changes that have been made. Still some of the changes were lost inadvertently, which I should have avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants