[BUGFIX] Add german short forms for weekdays and months #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parsing of a date fails, if there are some shortforms missing and used in the string, which mus be parsed. Adding these solves the issue. Solves: simplepie#631
|
So, this is not a bug. It's frustrating — sure — but not a bug. The RSS 2.0 specification defines dates as being RFC 822, which defines only english values. Anything that is non-english is invalid. That said, 15 years ago we made some exceptions for a couple of languages, so there is a precedent. @mblaney is the current maintainer of this project so I'll defer to his judgment on this PR, but I just wanted to clarify that this is not a bug in SimplePie — rather it's a bug in the feed. Syntactically, this PR looks correct. |
|
yes I agree @skyzyx, happy to improve the languages exception though thanks @mschwemer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parsing of a date fails, if there are some shortforms missing and
used in the string, which mus be parsed. Adding these solves the issue.
Fixes #631