Re-enable xml:base for all supported RSS formats #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts simplepie@e49c578 Specification, e.g. Atom: * https://datatracker.ietf.org/doc/html/rfc4287#section-2 > Any element defined by this specification MAY have an xml:base attribute While RSS 2.0 is silent on the matter https://cyber.harvard.edu/rss/relativeURI.html , here are examples of use from the same epoch: * https://rssweblog.com/?guid=20050627094747 * https://www.drupal.org/project/views/issues/943762
Alkarex
referenced
this pull request
Feb 27, 2022
8 tasks
Alkarex
referenced
this pull request
in FreshRSS/FreshRSS
Feb 27, 2022
And fix/revert `xml:base` support in SimplePie simplepie/simplepie@e49c578
|
To respond to @Alkarex's comment on e49c578#commitcomment-67585150:
I have absolutely no idea. 🙃 Quite possibly trying to avoid doing anything complex or treating RSS is ways more sophisticated than other implementations did? Clearly we should time travel and teach 15-year-old me how to write better commit messages. 😅 |
|
thanks @Alkarex seems ok if the tests still pass :-) |
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Feb 28, 2022
Alkarex
added a commit
to FreshRSS/FreshRSS
that referenced
this pull request
Feb 28, 2022
* More PHP type hints for Fever Follow-up of #4201 Related to #4200 * Detail * Draft * Progress * More draft * Fix thumbnail PHP type hint #4215 * More types * A bit more * Refactor FreshRSS_Entry::fromArray * Progress * Starts to work * Categories * Fonctional * Layout update * Fix relative URLs * Cache system * Forgotten files * Remove a debug line * Automatic form validation of XPath expressions * data-leave-validation * Fix reload action * Simpler examples * Fix column type for PostgreSQL * Enforce HTTP encoding * Readme * Fix get full content * target="_blank" * gitignore * htmlspecialchars_utf8 * Implement HTML <base> And fix/revert `xml:base` support in SimplePie simplepie/simplepie@e49c578 * SimplePie upstream PR merged simplepie/simplepie#723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimplePie already has the mechanism for supporting
xml:basebut it is disabled for some feed types.So this PR reverts the commit disabling it e49c578 (see also my question there)
Specification, e.g. Atom:
While RSS 2.0 is silent on the matter https://cyber.harvard.edu/rss/relativeURI.html , here are examples of use from the same epoch: