Fix parsing of HTTP Links #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, SimplePie was not able to parse an HTTP header such as: ``` Link: <https://pubsubhubbub.appspot.com>; rel="hub", <https://pubsubhubbub.superfeedr.com>; rel=hub, <https://websubhub.com/hub>; rel="hub" ``` The new regex complies with https://datatracker.ietf.org/doc/html/rfc8288 See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link Downstream: FreshRSS/FreshRSS#4283
jtojnar
reviewed
Apr 25, 2022
| if (!empty($matches)) { | ||
| return $matches; | ||
| // https://datatracker.ietf.org/doc/html/rfc8288 | ||
| if (is_string($link_headers) && |
There was a problem hiding this comment.
Can $this->data['headers']['link'] be anything other than array or string?
There was a problem hiding this comment.
I do not believe so. And this PR does not change the assumptions (there was already a case for array and string before).
There was a problem hiding this comment.
In that case, is not is_string($link_headers) redundant?
There was a problem hiding this comment.
Maybe, but it is not something that is currently enforced (e.g. through a type), and I have not checked in details
|
thanks @Alkarex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, SimplePie was not able to parse an HTTP header such as:
The new regex complies with https://datatracker.ietf.org/doc/html/rfc8288
See also https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Link
Downstream: FreshRSS/FreshRSS#4283