Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use magic values for state machine state #735

Merged
merged 2 commits into from
Jul 7, 2022
Merged

Do not use magic values for state machine state #735

merged 2 commits into from
Jul 7, 2022

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented May 19, 2022

Extracted from #734.

@jtojnar jtojnar mentioned this pull request May 19, 2022
Closed
@Art4
Copy link
Contributor

Art4 commented May 20, 2022

What do you think about marking the constants as @access private or @internal to communicate that they are for internal use only and are excluded from the backward compatibility promise.

@jtojnar
Copy link
Contributor Author

jtojnar commented May 20, 2022

Good point, ideally we would add constant visibility modifiers but those are only available in PHP 7.1.

@mblaney mblaney merged commit 398fe7d into simplepie:master Jul 7, 2022
@jtojnar jtojnar deleted the no-magic-parsers branch July 7, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Art4 Art4 Art4 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @Art4 @mblaney