Use native array_replace_recursive

[Alkarex]

Since PHP 5.3+, there is a native equivalent to the SimplePie Misc function to merge arrays: https://php.net/array-replace-recursive
Improvement of #268

[jtojnar]

Note that the functions are not equivalent. For example:

<?php

require_once __DIR__ . '/vendor/autoload.php';

use SimplePie\Misc;

var_dump(Misc::array_merge_recursive(['a' => 'b'], ['a' => ['b']]));
var_dump(array_replace_recursive(['a' => 'b'], ['a' => ['b']]));

prints

array(1) {
  ["a"]=>
  string(1) "b"
}
array(1) {
  ["a"]=>
  array(1) {
    [0]=>
    string(1) "b"
  }
}

Although the behaviour of array_replace_recursive makes more sense to me for a “replace” function and there probably won’t be arrays in the values we are merging.

[Alkarex]

Good catch :-) I do not think this was the intended behaviour of Misc::array_merge_recursive() and was probably an implementation bug (cf. #268 ). The native array_replace_recursive() indeed handles arrays better.

[Art4]

For BC reasons I would leave the Misc::array_merge_recursive() method untouched. I think that it is enough if we mark it as deprecated and no longer use it internally.

[Alkarex]

Done

[jtojnar]

Maybe also mention that the behaviour is slightly different in case someone really heeds this recommendation?

[Art4]

I don't think that's necessary. The developer must always check if and how one can use an offered alternative.