Item::get_date: fix return type on unparsable date #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Parse\Date::parse` method can return `false` when it fails to parse the value and `get_date` will return it as is but its PHPDoc annotation does not allow returning booleans. Let’s fix it by converting such values to `null`.
Art4
approved these changes
Oct 17, 2022
jtojnar
added a commit
to fossar/selfoss
that referenced
this pull request
Oct 19, 2022
When SimplePie is unable to parse an item update date, it will return `false`,
breaking the promise in PHPDoc. Since we do not expect it, we would try to treat
the non-null value as a an int and try to create a date object from it, which
lead to the affected sources failing to update with the following error:
Exception: DateTimeImmutable::__construct(): Failed to parse time string (@) at position 0 (@)
I have created an upstream PR:
simplepie/simplepie#753
But until that is available, let’s work around the issue by also guarding against `false`.
Closes: #1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Parse\Date::parsemethod can returnfalsewhen it fails to parse the value andget_datewill return it as is but its PHPDoc annotation does not allow returning booleans.Let’s fix it by converting such values to
null.Fixes: fossar/selfoss#1384