tests: Do not use magic method for testing protected methods #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jtojnar
force-pushed
the
test-no-magic-misc
branch
from
61852c7
to
38171c6
Compare
PHPStan will not know about those and complain:
Call to protected static method change_encoding_mbstring() of class SimplePie\Misc.
Call to protected static method change_encoding_iconv() of class SimplePie\Misc.
Call to protected static method change_encoding_uconverter() of class SimplePie\Misc.
We could use `@method` PHPDoc annotation but at this point explicit methods are not that much longer.
jtojnar
force-pushed
the
test-no-magic-misc
branch
from
38171c6
to
04a2281
Compare
Art4
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPStan will not know about those and complain:
We could use
@methodPHPDoc annotation but at this point explicit methods are not that much longer.