This repository has been archived by the owner on Feb 22, 2019. It is now read-only.
Add 'hostPoolSize' option to ConnectionPool #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the number of connections per host to be modified. Defaults to 1 if not specified.
|
Awesome, commit. I've been meaning to do this [ ref #21 ]. The only thing I ask before I pull is that a test get written for it. I want to ensure we don't break existing functionality. |
Fixes a bug where doing the counter initialization up top prevented connections to hosts after the first one.
|
I'll see if I can get some test coverage for this. I noticed that if I set multiple hosts in tests/helpers/connection.js it causes some tests to fail, and I suspect I can get a fix for that in with this as well. |
added 2 commits
September 18, 2012 13:05
In ConnectionPool.connect(), if the callback gets fired after making the first successfull connection then subsequent ConnectionPool.use() calls may not set the keyspace on the entire set of connections. This moves the callback to happen after the final connection is set.
Re-runs the existing thrift.js test suite, but sets the hostPoolSize option before starting.
|
OK, tests are ready and passing. The current suite of thrift.js tests just get imported and re-run with the hostPoolSize option set. Let me know if you see any issues... |
devdazed
added a commit
that referenced
this pull request
Sep 27, 2012
Add 'hostPoolSize' option to ConnectionPool
This was referenced Sep 28, 2012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small modification that allows the number connections per cluster host to be increased. Similar to the node-postgres module, which uses a pool of 10 'parallel' connections to the db, bumpng this number up increased the throughput of our app which was making a lot of asynchronous read requests to the cassandra db.