Cookie- and Set-Cookie-headers are missing in Chrome #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…how cookies in requests and responses.
thijskh
approved these changes
Oct 3, 2019
|
@jaimeperez, will you soon find the time to merge this PR? (And the other open PRs as well 😉) |
jaimeperez
approved these changes
Nov 18, 2019
|
Thanks @khlr! And sorry for the time it took me to have a look at this. The change looks good to me and the bug indeed is quite bad, so I'll take a look at the other PR and try to create a new release as soon as I'm able to. |
|
Thank you for creating the new release, Jaime 🙂 |
|
No problem at all! I just wish I had the time to be more responsive and get things released faster... |
|
I couldn't find my plugin anymore yesterday with the new logo 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a web application the other day I noticed that SAML-tracer doesn't record the
Cookie- orSet-Cookie-header in Chrome.This was a really lucky discovery since I usually don't use Chrome.
It's a quite sever bug as users of SAML-tracer in Chrome will mistakenly think that their applications don't issue cookies albeit in fact they do!
Why does this bug occur?
This is due to a change in Chrome 72: Starting from this version the
Cookie-,Set-Cookie- and some other headers are only accessible by specifyingextraHeadersinopt_extraInfoSpec.See: https://developer.chrome.com/extensions/webRequest
Hence I added this option, although there's one downside:
But I think there's no way to get around this. SAML-tracer has to inspect each request since there's always a chance for cookies being involved.