Bugfix: properly deal with unset AllowCreate

simplesamlphp · Jun 12, 2023 · 20c0dde · 20c0dde
1 parent 58c40d3
commit 20c0dde
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/SAML2/XML/samlp/NameIDPolicy.php b/src/SAML2/XML/samlp/NameIDPolicy.php
@@ -96,12 +96,12 @@ public static function fromXML(DOMElement $xml): static
 
         $Format = self::getOptionalAttribute($xml, 'Format', null);
         $SPNameQualifier = self::getOptionalAttribute($xml, 'SPNameQualifier', null);
-        $AllowCreate = self::getOptionalAttribute($xml, 'AllowCreate', null);
+        $AllowCreate = self::getOptionalBooleanAttribute($xml, 'AllowCreate', null);
 
         return new static(
             $Format,
             $SPNameQualifier,
-            ($AllowCreate === 'true') ? true : false,
+            $AllowCreate,
         );
     }