Remove PHPMD leftovers

simplesamlphp · Jan 17, 2019 · 4c60d32 · 4c60d32
1 parent 506de86
commit 4c60d32
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 22 deletions.
diff --git a/src/SAML2/Assertion/Processor.php b/src/SAML2/Assertion/Processor.php
@@ -17,9 +17,6 @@
 use SAML2\Signature\Validator;
 use SAML2\Utilities\ArrayCollection;
 
-/**
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects) - due to all the named exceptions
- */
 class Processor
 {
     /**

diff --git a/src/SAML2/Assertion/ProcessorBuilder.php b/src/SAML2/Assertion/ProcessorBuilder.php
@@ -30,8 +30,6 @@
  * Simple Builder that allows to build a new Assertion Processor.
  *
  * This is an excellent candidate for refactoring towards dependency injection
- *
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 final class ProcessorBuilder
 {

diff --git a/src/SAML2/Assertion/Transformer/DecodeBase64Transformer.php b/src/SAML2/Assertion/Transformer/DecodeBase64Transformer.php
@@ -53,7 +53,6 @@ public function transform(Assertion $assertion)
      * @param string $value
      *
      * @return array
-     * @SuppressWarnings(PHPMD.UnusedPrivateMethod)
      */
     private function decodeValue(string $value)
     {

diff --git a/src/SAML2/HTTPArtifact.php b/src/SAML2/HTTPArtifact.php
@@ -15,8 +15,6 @@
  *
  * @author  Danny Bollaert, UGent AS. <danny.bollaert@ugent.be>
  * @package SimpleSAMLphp
- *
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 final class HTTPArtifact extends Binding
 {

diff --git a/src/SAML2/HTTPRedirect.php b/src/SAML2/HTTPRedirect.php
@@ -97,7 +97,6 @@ public function send(Message $message)
      * @return \SAML2\Message The received message.
      *
      * NPath is currently too high but solving that just moves code around.
-     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function receive()
     {

diff --git a/src/SAML2/Message.php b/src/SAML2/Message.php
@@ -14,10 +14,6 @@
  *
  * Implements what is common between the samlp:RequestAbstractType and
  * samlp:StatusResponseType element types.
- *
- *
- * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 abstract class Message extends SignedElement
 {

diff --git a/src/SAML2/Response/Processor.php b/src/SAML2/Response/Processor.php
@@ -17,9 +17,6 @@
 use SAML2\Response\Validation\PreconditionValidator;
 use SAML2\Signature\Validator;
 
-/**
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects) - due to specific exceptions
- */
 final class Processor
 {
     /**

diff --git a/src/SAML2/SOAP.php b/src/SAML2/SOAP.php
@@ -73,8 +73,6 @@ public function getOutputToSend(Message $message)
      *
      * @param \SAML2\Message $message The message we should send.
      * @return void
-     *
-     * @SuppressWarnings(PHPMD.ExitExpression)
      */
     public function send(Message $message)
     {

diff --git a/src/SAML2/Utilities/ArrayCollection.php b/src/SAML2/Utilities/ArrayCollection.php
@@ -8,8 +8,6 @@
 
 /**
  * Simple Array implementation of Collection.
- *
- * @SuppressWarnings(PHPMD.TooManyMethods) - it just has a large api.
  */
 class ArrayCollection implements Collection
 {

diff --git a/src/SAML2/XML/md/Extensions.php b/src/SAML2/XML/md/Extensions.php
@@ -21,8 +21,6 @@
 
 /**
  * Class for handling SAML2 metadata extensions.
- * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
- *
  * @package SimpleSAMLphp
  */
 final class Extensions