Skip to content

Commit

Permalink
Add some documentation on that we purposefully require a 'Z' timezone…
Browse files Browse the repository at this point in the history
… component.

Fixes #39
  • Loading branch information
thijskh committed Oct 6, 2015
1 parent 69710e7 commit f89856e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/SAML2/Utils.php
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,11 @@ public static function createKeyDescriptor($x509Data)
* Therefore I added to possibility to have microseconds to the format.
* Added: (\.\\d{1,3})? to the regex.
*
* Note that we always require a 'Z' timezone for the dateTime to be valid.
* This is not in the SAML spec but that's considered to be a bug in the
* spec. See https://github.com/simplesamlphp/saml2/pull/36 for some
* background.
*
* @param string $time The time we should convert.
* @return int Converted to a unix timestamp.
* @throws Exception
Expand Down

0 comments on commit f89856e

Please sign in to comment.