Resolve last Psalm-issues

simplesamlphp · Jan 19, 2024 · a32c24b · a32c24b
1 parent 08843d5
commit a32c24b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml
@@ -82,7 +82,6 @@ jobs:
         run: phpcs
 
       - name: Psalm
-        continue-on-error: true
         run: |
           psalm -c psalm.xml \
           --show-info=true \

diff --git a/src/Controller/Authorize.php b/src/Controller/Authorize.php
@@ -48,7 +48,7 @@ public function __construct(
     public function forbidden(Request $request): Template
     {
         $stateId = $request->query->get('StateId', false);
-        if ($stateId === false) {
+        if (!is_string($stateId)) {
             throw new Error\BadRequest('Missing required StateId query parameter.');
         }