Fix codesniffer issues

simplesamlphp · Oct 24, 2023 · 7d2a599 · 7d2a599
1 parent eda262a
commit 7d2a599
Showing 1 changed file with 16 additions and 16 deletions.
diff --git a/tests/src/Controller/ConsentControllerTest.php b/tests/src/Controller/ConsentControllerTest.php
@@ -25,24 +25,24 @@
 class ConsentTest extends TestCase
 {
     /** @var \SimpleSAML\Configuration */
-    protected $config;
+    protected static Configuration $config;
 
     /** @var \SimpleSAML\Logger */
-    protected $logger;
+    protected static Logger $logger;
 
     /** @var \SimpleSAML\Session */
-    protected $session;
+    protected static Session $session;
 
 
     /**
      * Set up for each test.
      * @return void
      */
-    protected function setUp(): void
+    protected function setUpBeforeClass(): void
     {
         parent::setUp();
 
-        $this->config = Configuration::loadFromArray(
+        self::$config = Configuration::loadFromArray(
             [
                 'module.enable' => ['consent' => true],
                 'secretsalt' => 'abc123',
@@ -52,9 +52,9 @@ protected function setUp(): void
             'simplesaml'
         );
 
-        $this->session = Session::getSessionFromRequest();
+        self::$session = Session::getSessionFromRequest();
 
-        $this->logger = new class () extends Logger {
+        self::$logger = new class () extends Logger {
             public static function info(string $string): void
             {
                 // do nothing
@@ -75,7 +75,7 @@ public function testGetconsentAccept(): void
             ['yes' => '', 'saveconsent' => '1', 'StateId' => 'someStateId']
         );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
+        $c = new Controller\ConsentController(self::$config, self::$session);
         $c->setAuthState(new class () extends State {
             public static function loadState(string $id, string $stage, bool $allowMissing = false): ?array
             {
@@ -122,7 +122,7 @@ public function testGetconsentDecline(): void
             ['no' => '', 'StateId' => 'someStateId']
         );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
+        $c = new Controller\ConsentController(self::$config, self::$session);
         $c->setAuthState(new class () extends State {
             public static function loadState(string $id, string $stage, bool $allowMissing = false): ?array
             {
@@ -163,7 +163,7 @@ public function testNoconsent(): void
             ['StateId' => 'someStateId']
         );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
+        $c = new Controller\ConsentController(self::$config, self::$session);
         $c->setAuthState(new class () extends State {
             public static function loadState(string $id, string $stage, bool $allowMissing = false): ?array
             {
@@ -196,7 +196,7 @@ public function testLogout(): void
             ['StateId' => 'someStateId']
         );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
+        $c = new Controller\ConsentController(self::$config, self::$session);
         $c->setAuthState(new class () extends State {
             public static function loadState(string $id, string $stage, bool $allowMissing = false): ?array
             {
@@ -223,7 +223,7 @@ public function testLogoutcompleted(): void
 //            'GET'
 //        );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
+        $c = new Controller\ConsentController(self::$config, self::$session);
         $response = $c->logoutcompleted();
 
         $this->assertTrue($response->isSuccessful());
@@ -243,8 +243,8 @@ public function testMissingStateId(string $controller): void
             'GET'
         );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
-        $c->setLogger($this->logger);
+        $c = new Controller\ConsentController(self::$config, self::$session);
+        $c->setLogger(self::$logger);
 
         $this->expectException(Error\BadRequest::class);
         $this->expectExceptionMessage('Missing required StateId query parameter.');
@@ -267,8 +267,8 @@ public function testNoState(string $controller): void
             ['StateId' => 'someStateId']
         );
 
-        $c = new Controller\ConsentController($this->config, $this->session);
-        $c->setLogger($this->logger);
+        $c = new Controller\ConsentController(self::$config, self::$session);
+        $c->setLogger(self::$logger);
 
         $this->expectException(Error\NoState::class);
         $this->expectExceptionMessage('NOSTATE');