Merge pull request #1 from simplesamlphp/psalm

Add some missing functions to stub
simplesamlphp · Mar 25, 2019 · 73181fd · 73181fd
2 parents aca8101 + 0c28a48
commit 73181fd
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 2 deletions.
diff --git a/lib/Auth/Source/Radius.php b/lib/Auth/Source/Radius.php
@@ -123,7 +123,7 @@ public function __construct($info, $config)
      *
      * @param string $username  The username the user wrote.
      * @param string $password  The password the user wrote.
-     * @return array Associative array with the user's attributes.
+     * @return array[] Associative array with the user's attributes.
      */
     protected function login($username, $password)
     {
@@ -218,7 +218,7 @@ protected function login($username, $password)
             }
 
             // Use the received user name
-            if ($resa['attr'] == \RADIUS_USER_NAME) {
+            if ($resa['attr'] === \RADIUS_USER_NAME && $usernameAttribute !== null) {
                 $attributes[$usernameAttribute] = [$resa['data']];
                 continue;
             }

diff --git a/tests/Utils/Stubs/radius.php b/tests/Utils/Stubs/radius.php
@@ -405,3 +405,37 @@ function radius_create_request($radius_handle, $type)
 function radius_get_vendor_attr($data)
 {
 }
+
+/**
+ * Attaches a binary attribute
+ * @param resource $radius_handle
+ * @param int $type
+ * @param string $value
+ * @param int $options
+ * @param int $tag
+ * @return bool
+ * @since 1.1.0
+ */
+function radius_put_attr(resource $radius_handle, $type, $value, $options = 0, $tag = null)
+{
+}
+
+/**
+ * Extracts an attribute
+ * @param resource $radius_handle
+ * @return mixed
+ * @since 1.1.0
+ */
+function radius_get_attr($radius_handle)
+{
+}
+
+/**
+ * Returns an error message
+ * @param resource $radius_handle
+ * @return string
+ * @since 1.1.0
+ */
+function radius_strerror(resource $radius_handle)
+{
+}