Skip to content

Update test suite for no single string endpoints #5088

Update test suite for no single string endpoints

Update test suite for no single string endpoints #5088

Triggered via pull request June 15, 2024 08:27
Status Success
Total duration 2m 54s
Artifacts

php.yml

on: pull_request
Matrix: unit-tests-linux
Matrix: unit-tests-windows
Code coverage
11s
Code coverage
Cleanup artifacts
4s
Cleanup artifacts
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 20 warnings
Quality control
Process completed with exit code 1.
UndefinedClass: modules/adfs/src/Controller/Adfs.php#L74
modules/adfs/src/Controller/Adfs.php:74:24: UndefinedClass: Class, interface or enum named SimpleSAML\Module\adfs\Controller\RunnableResponse does not exist (see https://psalm.dev/019)
ArgumentTypeCoercion: modules/adfs/src/Controller/Adfs.php#L83
modules/adfs/src/Controller/Adfs.php:83:59: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig expects string, but parent type null|scalar provided (see https://psalm.dev/193)
PossiblyNullArgument: modules/adfs/src/Controller/Adfs.php#L83
modules/adfs/src/Controller/Adfs.php:83:59: PossiblyNullArgument: Argument 1 of SimpleSAML\Metadata\MetaDataStorageHandler::getMetaDataConfig cannot be null, possibly null value provided (see https://psalm.dev/078)
ArgumentTypeCoercion: modules/adfs/src/Controller/Adfs.php#L187
modules/adfs/src/Controller/Adfs.php:187:53: ArgumentTypeCoercion: Argument 1 of SimpleSAML\Metadata\SAMLBuilder::__construct expects string, but parent type null|scalar provided (see https://psalm.dev/193)
PossiblyNullArgument: modules/adfs/src/Controller/Adfs.php#L187
modules/adfs/src/Controller/Adfs.php:187:53: PossiblyNullArgument: Argument 1 of SimpleSAML\Metadata\SAMLBuilder::__construct cannot be null, possibly null value provided (see https://psalm.dev/078)
RiskyTruthyFalsyComparison: modules/adfs/src/Controller/Adfs.php#L205
modules/adfs/src/Controller/Adfs.php:205:41: RiskyTruthyFalsyComparison: Operand of type false|int<0, max> contains type int<0, max>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
RiskyTruthyFalsyComparison: modules/adfs/src/Controller/Adfs.php#L209
modules/adfs/src/Controller/Adfs.php:209:44: RiskyTruthyFalsyComparison: Operand of type false|int contains type int, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
ArgumentTypeCoercion: modules/adfs/src/Controller/Adfs.php#L256
modules/adfs/src/Controller/Adfs.php:256:48: ArgumentTypeCoercion: Argument 1 of SimpleSAML\IdP::handleLogoutResponse expects string, but parent type null|scalar provided (see https://psalm.dev/193)
PossiblyNullArgument: modules/adfs/src/Controller/Adfs.php#L256
modules/adfs/src/Controller/Adfs.php:256:48: PossiblyNullArgument: Argument 1 of SimpleSAML\IdP::handleLogoutResponse cannot be null, possibly null value provided (see https://psalm.dev/078)
ArgumentTypeCoercion: modules/adfs/src/Controller/Adfs.php#L256
modules/adfs/src/Controller/Adfs.php:256:58: ArgumentTypeCoercion: Argument 2 of SimpleSAML\IdP::handleLogoutResponse expects null|string, but parent type null|scalar provided (see https://psalm.dev/193)
MissingClassConstType: tests/SigningTestCase.php#L170
tests/SigningTestCase.php:170:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::ROOTDIRNAME" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L171
tests/SigningTestCase.php:171:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::DEFAULTCERTDIR" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L172
tests/SigningTestCase.php:172:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::CA_PRIVATE_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L173
tests/SigningTestCase.php:173:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::CA_CERTIFICATE" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L174
tests/SigningTestCase.php:174:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::GOOD_PRIVATE_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/SigningTestCase.php#L175
tests/SigningTestCase.php:175:21: MissingClassConstType: Class constant "SimpleSAML\Test\SigningTestCase::GOOD_CERTIFICATE" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L27
tests/modules/admin/src/Controller/FederationTest.php:27:19: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::SECURITY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L30
tests/modules/admin/src/Controller/FederationTest.php:30:19: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::FRAMEWORK" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L33
tests/modules/admin/src/Controller/FederationTest.php:33:19: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::LIBRARY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: tests/modules/admin/src/Controller/FederationTest.php#L36
tests/modules/admin/src/Controller/FederationTest.php:36:18: MissingClassConstType: Class constant "SimpleSAML\Test\Module\admin\Controller\FederationTest::CERT_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/adfs/src/SAML2/XML/fed/Constants.php#L18
modules/adfs/src/SAML2/XML/fed/Constants.php:18:18: MissingClassConstType: Class constant "SimpleSAML\Module\adfs\SAML2\XML\fed\Constants::NS_FED" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/admin/src/Controller/Config.php#L36
modules/admin/src/Controller/Config.php:36:18: MissingClassConstType: Class constant "SimpleSAML\Module\admin\Controller\Config::LATEST_VERSION_STATE_KEY" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/admin/src/Controller/Config.php#L38
modules/admin/src/Controller/Config.php:38:18: MissingClassConstType: Class constant "SimpleSAML\Module\admin\Controller\Config::RELEASES_API" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/RequestedAuthnContextSelector.php#L26
modules/core/src/Auth/Source/RequestedAuthnContextSelector.php:26:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\RequestedAuthnContextSelector::AUTHID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/RequestedAuthnContextSelector.php#L31
modules/core/src/Auth/Source/RequestedAuthnContextSelector.php:31:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\RequestedAuthnContextSelector::STAGEID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/RequestedAuthnContextSelector.php#L36
modules/core/src/Auth/Source/RequestedAuthnContextSelector.php:36:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\RequestedAuthnContextSelector::SOURCESID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/SourceIPSelector.php#L25
modules/core/src/Auth/Source/SourceIPSelector.php:25:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\SourceIPSelector::AUTHID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/SourceIPSelector.php#L30
modules/core/src/Auth/Source/SourceIPSelector.php:30:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\SourceIPSelector::STAGEID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/Source/SourceIPSelector.php#L35
modules/core/src/Auth/Source/SourceIPSelector.php:35:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\Source\SourceIPSelector::SOURCESID" should have a declared type. (see https://psalm.dev/359)
MissingClassConstType: modules/core/src/Auth/UserPassBase.php#L29
modules/core/src/Auth/UserPassBase.php:29:18: MissingClassConstType: Class constant "SimpleSAML\Module\core\Auth\UserPassBase::STAGEID" should have a declared type. (see https://psalm.dev/359)