Stop using string issuers

simplesamlphp · Sep 13, 2019 · 18b7fa1 · 18b7fa1
1 parent 3613848
commit 18b7fa1
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/modules/saml/lib/IdP/SAML2.php b/modules/saml/lib/IdP/SAML2.php
@@ -368,13 +368,8 @@ public static function receiveAuthnRequest(\SimpleSAML\IdP $idp)
                 throw new Error\BadRequest(
                     'Received message on authentication request endpoint without issuer.'
                 );
-            } else {
-                $spEntityId = $issuer->getValue();
-                if ($spEntityId === null) {
-                    /* Without an issuer we have no way to respond to the message. */
-                    throw new Error\BadRequest('Received message on logout endpoint without issuer.');
-                }
             }
+            $spEntityId = $issuer->getValue();
             $spMetadata = $metadata->getMetaDataConfig($spEntityId, 'saml20-sp-remote');
 
             \SimpleSAML\Module\saml\Message::validateMessage($spMetadata, $idpMetadata, $request);