Add Support for custom error messages #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1326 +/- ##
=============================================
+ Coverage 0 44.48% +44.48%
- Complexity 0 3449 +3449
=============================================
Files 0 139 +139
Lines 0 10324 +10324
=============================================
+ Hits 0 4593 +4593
- Misses 0 5731 +5731 |
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
1c686ab
to
eb20457
Compare
tvdijen
approved these changes
Mar 11, 2021
|
Eligable for backport to 1.19 |
thijskh
approved these changes
Mar 12, 2021
|
Just needs conflicts to be resolved. |
tvdijen
added a commit
that referenced
this pull request
Mar 12, 2021
Co-authored-by: Tim van Dijen <tim.dijen@minbzk.nl>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support custom error messages again (e.g.
SimpleSAML\Error\Error('{mymodule:error:CUSTOMERROR}')).After merging d48f2bf custom error messages lead to unexpected error messages instead of showing customized content.
This change does not affect the way error messages were introduced in the former commit.