Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show overview of modules in the admin plugin #1561

Merged
merged 1 commit into from Jan 18, 2022

Conversation

thijskh
Copy link
Member

@thijskh thijskh commented Jan 18, 2022

Previously, the admin module did not provide any information about which modules you have installed or wheter they are enabled. This seems a logical thing to show there.

This is now combined with the "SAML 2.0 IdP" enabled/disabled flag
which was a bit lonely before, as it's the only flag of its type.

Screenshot showing a table of modules with enabled or disabled icons behind them in the admin module's configuration page

This is now combined with the "SAML 2.0 IdP" enabled/disabled flag
which was a bit lonely before, as it's the only flag of its type.
@thijskh thijskh requested a review from tvdijen January 18, 2022 15:43
@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1561 (0547855) into master (51e3e55) will decrease coverage by 0.68%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1561      +/-   ##
============================================
- Coverage     42.39%   41.70%   -0.69%     
- Complexity     3427     3604     +177     
============================================
  Files           144      144              
  Lines         10330    10813     +483     
============================================
+ Hits           4379     4510     +131     
- Misses         5951     6303     +352     

@tvdijen
Copy link
Member

tvdijen commented Jan 18, 2022

I'm not sure... You've kinda reinvented the modinfo-module here...

@thijskh
Copy link
Member Author

thijskh commented Jan 18, 2022

Yes. But:

  • I think this information really belongs in the admin module, is actually a core part of its functionality. The config page shows various parts of your config, it really seems logical to me that which modules you've enabled is quite an important part, maybe the most important part, of your config.
  • It does not make much sense to require users to fetch a separate module, enable it (!), and only then see simply what modules are installed and are enabled.
  • Given it's only 10 lines of code and a few lines of template, having that hosted in its own separate module with all the overhead seems overkill.

@tvdijen
Copy link
Member

tvdijen commented Jan 18, 2022

I'm fine with it, but can we archive the modinfo-module then, to reduce maintenance?

@thijskh
Copy link
Member Author

thijskh commented Jan 18, 2022

Definitely!

@tvdijen tvdijen merged commit f3929ac into master Jan 18, 2022
@tvdijen tvdijen deleted the feature/show-modules-in-admin branch January 18, 2022 20:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants