Prefix cannot be empty for namespaced attributes

simplesamlphp · Jun 4, 2023 · 3b7f5f5 · 3b7f5f5
1 parent d9597fa
commit 3b7f5f5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/Attribute.php b/src/Attribute.php
@@ -34,6 +34,9 @@ public function __construct(
         Assert::nullOrStringNotEmpty($namespaceURI);
         Assert::string($namespacePrefix);
         Assert::notSame('xmlns', $namespacePrefix);
+        if ($namespaceURI !== null) {
+            Assert::stringNotEmpty($namespacePrefix);
+        }
         Assert::stringNotEmpty($attrName);
         Assert::string($attrValue);
     }

diff --git a/tests/XML/ExtendableAttributesTraitTest.php b/tests/XML/ExtendableAttributesTraitTest.php
@@ -42,7 +42,7 @@ public static function setUpBeforeClass(): void
     {
         self::$local = new Attribute(null, '', 'some', 'localValue');
 
-        self::$target = new Attribute('urn:x-simplesamlphp:namespace', '', 'some', 'targetValue');
+        self::$target = new Attribute('urn:x-simplesamlphp:namespace', 'ssp', 'some', 'targetValue');
 
         self::$other = new Attribute('urn:custom:dummy', 'dummy', 'some', 'dummyValue');
     }