-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to udemy API, fixes: #1 and update to Kafka 1.1.1 / Cofluent 5.0.1 #2
Conversation
...oducer/src/main/java/com/github/simplesteph/kafka/producer/udemy/client/UdemyRESTClient.java
Outdated
Show resolved
Hide resolved
...oducer/src/main/java/com/github/simplesteph/kafka/producer/udemy/client/UdemyRESTClient.java
Outdated
Show resolved
Hide resolved
@@ -3,7 +3,6 @@ | |||
"type": "record", | |||
"name": "User", | |||
"fields": [ | |||
{"name": "id", "type": "long", "doc": "User ID in Udemy's DB"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user node no longer reveals their ID. Perhaps it was a security issue, who knows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this. Just some minor changes to revert and I'll merge!
config.put(StreamsConfig.APPLICATION_ID_CONFIG, appConfig.getApplicationId()); | ||
config.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, appConfig.getBootstrapServers()); | ||
config.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest"); | ||
config.put(APPLICATION_ID_CONFIG, appConfig.getApplicationId()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please revert those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I will revert those code style changes today.
thanks @matiwinnetou for the contribution! Looks great :) |
It turns out udemy API removed @default, so now one has to enumerate all fields one wants. This fixes test error issue found in: #1