Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS 1.1 or TLS 1.2 support #34

Open
josemanuelsh opened this issue Sep 22, 2016 · 3 comments
Open

TLS 1.1 or TLS 1.2 support #34

josemanuelsh opened this issue Sep 22, 2016 · 3 comments
Labels

Comments

@josemanuelsh
Copy link

Hello,
I am trying to access https://xxx.my.salesforce.com/ using SimpleBrowser, but I get a message from the website to use a browser that supports TLS 1.1 or TLS 1.2 because SourceForce disabled TLS 1.0. There is a public announcement at https://help.salesforce.com/HTViewSolution?id=000221207.
Is there a way to enable TLS 1.1 or TLS 1.2 using SimpleBrowser?
Thanks!

@jakoch
Copy link
Member

jakoch commented Sep 22, 2016

Hey Jose,

i was able to reproduce the issue using this test.

You run into this issue because https:// requests are done using tls:// (version 1).

We need to change this behaviour in SimpleTest and support tlsv1.1 and tlsv1.2,
basically all configured secure transports as listed by stream_get_transports().

Workaround
You could edit the file socket.php and replace tls with tlsv1.1 (tlsv1.2)
in class SimpleSecureSocket function openSocket().

public function openSocket($host, $port, &$error_number, &$error, $timeout)
{
    return parent::openSocket("tlsv1.1://$host", $port, $error_number, $error, $timeout);
}

Reminder: watch the dot in tlsv1.1 - (i tend to write tlsv11, which doesn't work)

After the edit, the test passes:

$ php test_issue34.php
test_issue34.php
OK
Test cases run: 1/1, Passes: 5, Failures: 0, Exceptions: 0

Regards, Jens

@jakoch jakoch added the bug label Sep 22, 2016
jakoch added a commit that referenced this issue Sep 22, 2016
@josemanuelsh
Copy link
Author

Great! That worked! Thank you very much!

@jakoch
Copy link
Member

jakoch commented Sep 22, 2016

Glad i could help!

Re-opening the issue, because i have to bugfix SimpleTest first, before we can close :)

@jakoch jakoch reopened this Sep 22, 2016
@jakoch jakoch removed the verify bug label Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants