-
Notifications
You must be signed in to change notification settings - Fork 0
/
ads.go
954 lines (837 loc) · 31.1 KB
/
ads.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
// Copyright 2017 Istio Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package v2
import (
"context"
"errors"
"io"
"reflect"
"sort"
"sync"
"sync/atomic"
"time"
adminapi "github.com/envoyproxy/go-control-plane/envoy/admin/v2alpha"
xdsapi "github.com/envoyproxy/go-control-plane/envoy/api/v2"
ads "github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2"
"github.com/gogo/protobuf/types"
"github.com/prometheus/client_golang/prometheus"
"google.golang.org/grpc"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/peer"
"google.golang.org/grpc/status"
"istio.io/istio/pilot/pkg/model"
"istio.io/istio/pilot/pkg/networking/util"
istiolog "istio.io/istio/pkg/log"
)
var (
adsLog = istiolog.RegisterScope("ads", "ads debugging", 0)
// adsClients reflect active gRPC channels, for both ADS and EDS.
adsClients = map[string]*XdsConnection{}
adsClientsMutex sync.RWMutex
// Map of sidecar IDs to XdsConnections, first key is sidecarID, second key is connID
// This is a map due to an edge case during envoy restart whereby the 'old' envoy
// reconnects after the 'new/restarted' envoy
adsSidecarIDConnectionsMap = map[string]map[string]*XdsConnection{}
// SendTimeout is the max time to wait for a ADS send to complete. This helps detect
// clients in a bad state (not reading). In future it may include checking for ACK
SendTimeout = 5 * time.Second
// PushTimeout is the time to wait for a push on a client. Pilot iterates over
// clients and pushes them serially for now, to avoid large CPU/memory spikes.
// We measure and reports cases where pushing a client takes longer.
PushTimeout = 5 * time.Second
)
var (
timeZero time.Time
)
var (
// experiment on getting some monitoring on config errors.
cdsReject = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Name: "pilot_xds_cds_reject",
Help: "Pilot rejected CSD configs.",
}, []string{"node", "err"})
edsReject = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Name: "pilot_xds_eds_reject",
Help: "Pilot rejected EDS.",
}, []string{"node", "err"})
edsInstances = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Name: "pilot_xds_eds_instances",
Help: "Instances for each cluster, as of last push. Zero instances is an error.",
}, []string{"cluster"})
ldsReject = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Name: "pilot_xds_lds_reject",
Help: "Pilot rejected LDS.",
}, []string{"node", "err"})
rdsReject = prometheus.NewGaugeVec(prometheus.GaugeOpts{
Name: "pilot_xds_rds_reject",
Help: "Pilot rejected RDS.",
}, []string{"node", "err"})
rdsExpiredNonce = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_rds_expired_nonce",
Help: "Total number of RDS messages with an expired nonce.",
})
totalXDSRejects = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_total_xds_rejects",
Help: "Total number of XDS responses from pilot rejected by proxy.",
})
monServices = prometheus.NewGauge(prometheus.GaugeOpts{
Name: "pilot_services",
Help: "Total services known to pilot.",
})
// TODO: Update all the resource stats in separate routine
// virtual services, destination rules, gateways, etc.
monVServices = prometheus.NewGauge(prometheus.GaugeOpts{
Name: "pilot_virt_services",
Help: "Total virtual services known to pilot.",
})
xdsClients = prometheus.NewGauge(prometheus.GaugeOpts{
Name: "pilot_xds",
Help: "Number of endpoints connected to this pilot using XDS.",
})
xdsResponseWriteTimeouts = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_xds_write_timeout",
Help: "Pilot XDS response write timeouts.",
})
pushTimeouts = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_xds_push_timeout",
Help: "Pilot push timeout, will retry.",
})
pushTimeoutFailures = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_xds_push_timeout_failures",
Help: "Pilot push timeout failures after repeated attempts.",
})
// Covers xds_builderr and xds_senderr for xds in {lds, rds, cds, eds}.
pushes = prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "pilot_xds_pushes",
Help: "Pilot build and send errors for lds, rds, cds and eds.",
}, []string{"type"})
pushErrors = prometheus.NewCounterVec(prometheus.CounterOpts{
Name: "pilot_xds_push_errors",
Help: "Number of errors (timeouts) pushing to sidecars.",
}, []string{"type"})
proxiesConvergeDelay = prometheus.NewHistogram(prometheus.HistogramOpts{
Name: "pilot_proxy_convergence_time",
Help: "Delay between config change and all proxies converging.",
Buckets: []float64{.01, .1, 1, 3, 5, 10, 30},
})
pushContextErrors = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_xds_push_context_errors",
Help: "Number of errors (timeouts) initiating push context.",
})
totalXDSInternalErrors = prometheus.NewCounter(prometheus.CounterOpts{
Name: "pilot_total_xds_internal_errors",
Help: "Total number of internal XDS errors in pilot (check logs).",
})
)
func init() {
prometheus.MustRegister(cdsReject)
prometheus.MustRegister(edsReject)
prometheus.MustRegister(ldsReject)
prometheus.MustRegister(rdsReject)
prometheus.MustRegister(rdsExpiredNonce)
prometheus.MustRegister(totalXDSRejects)
prometheus.MustRegister(edsInstances)
prometheus.MustRegister(monServices)
prometheus.MustRegister(monVServices)
prometheus.MustRegister(xdsClients)
prometheus.MustRegister(xdsResponseWriteTimeouts)
prometheus.MustRegister(pushTimeouts)
prometheus.MustRegister(pushTimeoutFailures)
prometheus.MustRegister(pushes)
prometheus.MustRegister(pushErrors)
prometheus.MustRegister(proxiesConvergeDelay)
prometheus.MustRegister(pushContextErrors)
prometheus.MustRegister(totalXDSInternalErrors)
}
// DiscoveryStream is a common interface for EDS and ADS. It also has a
// shorter name.
type DiscoveryStream interface {
Send(*xdsapi.DiscoveryResponse) error
Recv() (*xdsapi.DiscoveryRequest, error)
grpc.ServerStream
}
// XdsConnection is a listener connection type.
type XdsConnection struct {
// Mutex to protect changes to this XDS connection
mu sync.RWMutex
// PeerAddr is the address of the client envoy, from network layer
PeerAddr string
// Time of connection, for debugging
Connect time.Time
// ConID is the connection identifier, used as a key in the connection table.
// Currently based on the node name and a counter.
ConID string
modelNode *model.Proxy
// Sending on this channel results in a push. We may also make it a channel of objects so
// same info can be sent to all clients, without recomputing.
pushChannel chan *XdsEvent
// TODO: migrate other fields as needed from model.Proxy and replace it
//HttpConnectionManagers map[string]*http_conn.HttpConnectionManager
LDSListeners []*xdsapi.Listener `json:"-"`
RouteConfigs map[string]*xdsapi.RouteConfiguration `json:"-"`
CDSClusters []*xdsapi.Cluster
// Last nonce sent and ack'd (timestamps) used for debugging
ClusterNonceSent, ClusterNonceAcked string
ListenerNonceSent, ListenerNonceAcked string
RouteNonceSent, RouteNonceAcked string
RouteVersionInfoSent string
EndpointNonceSent, EndpointNonceAcked string
EndpointPercent int
// current list of clusters monitored by the client
Clusters []string
// Both ADS and EDS streams implement this interface
stream DiscoveryStream
// Routes is the list of watched Routes.
Routes []string
// LDSWatch is set if the remote server is watching Listeners
LDSWatch bool
// CDSWatch is set if the remote server is watching Clusters
CDSWatch bool
// added will be true if at least one discovery request was received, and the connection
// is added to the map of active.
added bool
// Time of last push
LastPush time.Time
// Time of last push failure.
LastPushFailure time.Time
// pushMutex prevents 2 overlapping pushes for this connection.
pushMutex sync.Mutex
}
// configDump converts the connection internal state into an Envoy Admin API config dump proto
// It is used in debugging to create a consistent object for comparison between Envoy and Pilot outputs
func (s *DiscoveryServer) configDump(conn *XdsConnection) (*adminapi.ConfigDump, error) {
dynamicActiveClusters := []adminapi.ClustersConfigDump_DynamicCluster{}
clusters, err := s.generateRawClusters(conn.modelNode, s.globalPushContext())
if err != nil {
return nil, err
}
for _, cs := range clusters {
dynamicActiveClusters = append(dynamicActiveClusters, adminapi.ClustersConfigDump_DynamicCluster{Cluster: cs})
}
clustersAny, err := types.MarshalAny(&adminapi.ClustersConfigDump{
VersionInfo: versionInfo(),
DynamicActiveClusters: dynamicActiveClusters,
})
if err != nil {
return nil, err
}
dynamicActiveListeners := []adminapi.ListenersConfigDump_DynamicListener{}
listeners, err := s.generateRawListeners(conn, s.globalPushContext())
if err != nil {
return nil, err
}
for _, cs := range listeners {
dynamicActiveListeners = append(dynamicActiveListeners, adminapi.ListenersConfigDump_DynamicListener{Listener: cs})
}
listenersAny, err := types.MarshalAny(&adminapi.ListenersConfigDump{
VersionInfo: versionInfo(),
DynamicActiveListeners: dynamicActiveListeners,
})
if err != nil {
return nil, err
}
routes, err := s.generateRawRoutes(conn, s.globalPushContext())
if err != nil {
return nil, err
}
routeConfigAny, _ := types.MarshalAny(&adminapi.RoutesConfigDump{})
if len(routes) > 0 {
dynamicRouteConfig := []adminapi.RoutesConfigDump_DynamicRouteConfig{}
for _, rs := range routes {
dynamicRouteConfig = append(dynamicRouteConfig, adminapi.RoutesConfigDump_DynamicRouteConfig{RouteConfig: rs})
}
routeConfigAny, err = types.MarshalAny(&adminapi.RoutesConfigDump{DynamicRouteConfigs: dynamicRouteConfig})
if err != nil {
return nil, err
}
}
bootstrapAny, _ := types.MarshalAny(&adminapi.BootstrapConfigDump{})
// The config dump must have all configs with order specified in
// https://www.envoyproxy.io/docs/envoy/latest/api-v2/admin/v2alpha/config_dump.proto
configDump := &adminapi.ConfigDump{Configs: []types.Any{*bootstrapAny, *clustersAny, *listenersAny, *routeConfigAny}}
return configDump, nil
}
// XdsEvent represents a config or registry event that results in a push.
type XdsEvent struct {
// If not empty, it is used to indicate the event is caused by a change in the clusters.
// Only EDS for the listed clusters will be sent.
edsUpdatedServices map[string]struct{}
push *model.PushContext
pending *int32
version string
}
func newXdsConnection(peerAddr string, stream DiscoveryStream) *XdsConnection {
return &XdsConnection{
pushChannel: make(chan *XdsEvent),
PeerAddr: peerAddr,
Clusters: []string{},
Connect: time.Now(),
stream: stream,
LDSListeners: []*xdsapi.Listener{},
RouteConfigs: map[string]*xdsapi.RouteConfiguration{},
}
}
func receiveThread(con *XdsConnection, reqChannel chan *xdsapi.DiscoveryRequest, errP *error) {
defer close(reqChannel) // indicates close of the remote side.
for {
req, err := con.stream.Recv()
if err != nil {
if status.Code(err) == codes.Canceled || err == io.EOF {
con.mu.RLock()
adsLog.Infof("ADS: %q %s terminated %v", con.PeerAddr, con.ConID, err)
con.mu.RUnlock()
return
}
*errP = err
adsLog.Errorf("ADS: %q %s terminated with errors %v", con.PeerAddr, con.ConID, err)
totalXDSInternalErrors.Add(1)
return
}
select {
case reqChannel <- req:
case <-con.stream.Context().Done():
adsLog.Errorf("ADS: %q %s terminated with stream closed", con.PeerAddr, con.ConID)
return
}
}
}
// StreamAggregatedResources implements the ADS interface.
func (s *DiscoveryServer) StreamAggregatedResources(stream ads.AggregatedDiscoveryService_StreamAggregatedResourcesServer) error {
peerInfo, ok := peer.FromContext(stream.Context())
peerAddr := "0.0.0.0"
if ok {
peerAddr = peerInfo.Addr.String()
}
t0 := time.Now()
// rate limit the herd, after restart all endpoints will reconnect to the
// poor new pilot and overwhelm it.
// TODO: instead of readiness probe, let endpoints connect and wait here for
// config to become stable. Will better spread the load.
s.initRateLimiter.Wait(context.TODO())
// first call - lazy loading, in tests. This should not happen if readiness
// check works, since it assumes ClearCache is called (and as such PushContext
// is initialized)
// InitContext returns immediately if the context was already initialized.
err := s.globalPushContext().InitContext(s.Env)
if err != nil {
// Error accessing the data - log and close, maybe a different pilot replica
// has more luck
adsLog.Warnf("Error reading config %v", err)
return err
}
con := newXdsConnection(peerAddr, stream)
// Do not call: defer close(con.pushChannel) !
// the push channel will be garbage collected when the connection is no longer used.
// Closing the channel can cause subtle race conditions with push. According to the spec:
// "It's only necessary to close a channel when it is important to tell the receiving goroutines that all data
// have been sent."
// Reading from a stream is a blocking operation. Each connection needs to read
// discovery requests and wait for push commands on config change, so we add a
// go routine. If go grpc adds gochannel support for streams this will not be needed.
// This also detects close.
var receiveError error
reqChannel := make(chan *xdsapi.DiscoveryRequest, 1)
go receiveThread(con, reqChannel, &receiveError)
for {
// Block until either a request is received or a push is triggered.
select {
case discReq, ok := <-reqChannel:
if !ok {
// Remote side closed connection.
return receiveError
}
err = s.initConnectionNode(discReq, con)
if err != nil {
return err
}
switch discReq.TypeUrl {
case ClusterType:
if con.CDSWatch {
// Already received a cluster watch request, this is an ACK
if discReq.ErrorDetail != nil {
adsLog.Warnf("ADS:CDS: ACK ERROR %v %s %v", peerAddr, con.ConID, discReq.String())
cdsReject.With(prometheus.Labels{"node": discReq.Node.Id, "err": discReq.ErrorDetail.Message}).Add(1)
totalXDSRejects.Add(1)
} else if discReq.ResponseNonce != "" {
con.ClusterNonceAcked = discReq.ResponseNonce
}
adsLog.Debugf("ADS:CDS: ACK %v %v", peerAddr, discReq.String())
continue
}
// CDS REQ is the first request an envoy makes. This shows up
// immediately after connect. It is followed by EDS REQ as
// soon as the CDS push is returned.
adsLog.Infof("ADS:CDS: REQ %v %s %v raw: %s", peerAddr, con.ConID, time.Since(t0), discReq.String())
con.CDSWatch = true
err := s.pushCds(con, s.globalPushContext(), versionInfo())
if err != nil {
return err
}
case ListenerType:
if con.LDSWatch {
// Already received a cluster watch request, this is an ACK
if discReq.ErrorDetail != nil {
adsLog.Warnf("ADS:LDS: ACK ERROR %v %s %v", peerAddr, con.modelNode.ID, discReq.String())
ldsReject.With(prometheus.Labels{"node": discReq.Node.Id, "err": discReq.ErrorDetail.Message}).Add(1)
totalXDSRejects.Add(1)
} else if discReq.ResponseNonce != "" {
con.ListenerNonceAcked = discReq.ResponseNonce
}
adsLog.Debugf("ADS:LDS: ACK %v", discReq.String())
continue
}
// too verbose - sent immediately after EDS response is received
adsLog.Debugf("ADS:LDS: REQ %s %v", con.ConID, peerAddr)
con.LDSWatch = true
err := s.pushLds(con, s.globalPushContext(), versionInfo())
if err != nil {
return err
}
case RouteType:
if discReq.ErrorDetail != nil {
adsLog.Warnf("ADS:RDS: ACK ERROR %v %s (%s) %v", peerAddr, con.ConID, con.modelNode.ID, discReq.String())
rdsReject.With(prometheus.Labels{"node": discReq.Node.Id, "err": discReq.ErrorDetail.Message}).Add(1)
totalXDSRejects.Add(1)
continue
}
routes := discReq.GetResourceNames()
var sortedRoutes []string
if discReq.ResponseNonce != "" {
con.mu.RLock()
routeNonceSent := con.RouteNonceSent
routeVersionInfoSent := con.RouteVersionInfoSent
con.mu.RUnlock()
if routeNonceSent != "" && routeNonceSent != discReq.ResponseNonce {
adsLog.Debugf("ADS:RDS: Expired nonce received %s %s (%v), sent %s, received %s",
peerAddr, con.ConID, con.modelNode, routeNonceSent, discReq.ResponseNonce)
rdsExpiredNonce.Inc()
continue
}
if discReq.VersionInfo == routeVersionInfoSent {
sort.Strings(routes)
sortedRoutes = routes
if reflect.DeepEqual(con.Routes, sortedRoutes) {
adsLog.Debugf("ADS:RDS: ACK %s %s (%v) %s %s", peerAddr, con.ConID, con.modelNode, discReq.VersionInfo, discReq.ResponseNonce)
con.mu.Lock()
con.RouteNonceAcked = discReq.ResponseNonce
con.mu.Unlock()
continue
}
} else if discReq.ErrorDetail != nil || routes == nil {
// If versions mismatch then we should either have an error detail or no routes if a protocol error has occurred
if discReq.ErrorDetail != nil {
adsLog.Warnf("ADS:RDS: ACK ERROR %v %s (%v) %v", peerAddr, con.ConID, con.modelNode, discReq.String())
rdsReject.With(prometheus.Labels{"node": discReq.Node.Id, "err": discReq.ErrorDetail.Message}).Add(1)
totalXDSRejects.Add(1)
} else { // protocol error
adsLog.Warnf("ADS:RDS: ACK PROTOCOL ERROR %v %s (%v) %v", peerAddr, con.ConID, con.modelNode, discReq.String())
rdsReject.With(prometheus.Labels{"node": discReq.Node.Id, "err": "Protocol error"}).Add(1)
totalXDSRejects.Add(1)
continue
}
continue
}
}
if sortedRoutes == nil {
sort.Strings(routes)
sortedRoutes = routes
}
con.Routes = sortedRoutes
adsLog.Debugf("ADS:RDS: REQ %s %s routes: %d", peerAddr, con.ConID, len(con.Routes))
err := s.pushRoute(con, s.globalPushContext())
if err != nil {
return err
}
case EndpointType:
if discReq.ErrorDetail != nil {
adsLog.Warnf("ADS:EDS: ACK ERROR %v %s %v", peerAddr, con.ConID, discReq.String())
edsReject.With(prometheus.Labels{"node": discReq.Node.Id, "err": discReq.ErrorDetail.Message}).Add(1)
totalXDSRejects.Add(1)
continue
}
clusters := discReq.GetResourceNames()
if clusters == nil && discReq.ResponseNonce != "" {
// There is no requirement that ACK includes clusters. The test doesn't.
con.mu.Lock()
con.EndpointNonceAcked = discReq.ResponseNonce
con.mu.Unlock()
continue
}
// clusters and con.Clusters are all empty, this is not an ack and will do nothing.
if len(clusters) == 0 && len(con.Clusters) == 0 {
continue
}
if len(clusters) == len(con.Clusters) {
sort.Strings(clusters)
sort.Strings(con.Clusters)
// Already got a list of endpoints to watch and it is the same as the request, this is an ack
if reflect.DeepEqual(con.Clusters, clusters) {
adsLog.Debugf("ADS:EDS: ACK %s %s (%s) %s %s", peerAddr, con.ConID, con.modelNode.ID, discReq.VersionInfo, discReq.ResponseNonce)
if discReq.ResponseNonce != "" {
con.mu.Lock()
con.EndpointNonceAcked = discReq.ResponseNonce
if len(edsClusters) != 0 {
con.EndpointPercent = int((float64(len(clusters)) / float64(len(edsClusters))) * float64(100))
}
con.mu.Unlock()
}
continue
}
}
for _, cn := range con.Clusters {
s.removeEdsCon(cn, con.ConID, con)
}
for _, cn := range clusters {
s.addEdsCon(cn, con.ConID, con)
}
con.Clusters = clusters
adsLog.Debugf("ADS:EDS: REQ %s %s clusters: %d", peerAddr, con.ConID, len(con.Clusters))
err := s.pushEds(s.globalPushContext(), con, nil)
if err != nil {
return err
}
default:
adsLog.Warnf("ADS: Unknown watched resources %s", discReq.String())
}
if !con.added {
con.added = true
s.addCon(con.ConID, con)
defer s.removeCon(con.ConID, con)
}
case pushEv := <-con.pushChannel:
// It is called when config changes.
// This is not optimized yet - we should detect what changed based on event and only
// push resources that need to be pushed.
// TODO: possible race condition: if a config change happens while the envoy
// was getting the initial config, between LDS and RDS, the push will miss the
// monitored 'routes'. Same for CDS/EDS interval.
// It is very tricky to handle due to the protocol - but the periodic push recovers
// from it.
err := s.pushConnection(con, pushEv)
if err != nil {
return nil
}
}
}
}
// update the node associated with the connection, after receiving a a packet from envoy.
func (s *DiscoveryServer) initConnectionNode(discReq *xdsapi.DiscoveryRequest, con *XdsConnection) error {
con.mu.RLock() // may not be needed - once per connection, but locking for consistency.
if con.modelNode != nil {
con.mu.RUnlock()
return nil // only need to init the node on first request in the stream
}
con.mu.RUnlock()
if discReq.Node == nil || discReq.Node.Id == "" {
return errors.New("missing node id")
}
nt, err := model.ParseServiceNodeWithMetadata(discReq.Node.Id, model.ParseMetadata(discReq.Node.Metadata))
if err != nil {
return err
}
// Update the config namespace associated with this proxy
nt.ConfigNamespace = model.GetProxyConfigNamespace(nt)
locality := model.GetProxyLocality(discReq.Node)
if locality == nil {
locality := s.Env.GetProxyLocality(nt)
region, zone, subzone := util.SplitLocality(locality)
nt.Locality = model.Locality{
Region: region,
Zone: zone,
SubZone: subzone,
}
} else {
nt.Locality = *locality
}
con.mu.Lock()
con.modelNode = nt
if con.ConID == "" {
// first request
con.ConID = connectionID(discReq.Node.Id)
}
con.mu.Unlock()
// Set the sidecarScope associated with this proxy if its a sidecar.
if con.modelNode.Type == model.SidecarProxy {
s.globalPushContext().SetSidecarScope(con.modelNode)
}
return nil
}
// IncrementalAggregatedResources is not implemented.
func (s *DiscoveryServer) IncrementalAggregatedResources(stream ads.AggregatedDiscoveryService_IncrementalAggregatedResourcesServer) error {
return status.Errorf(codes.Unimplemented, "not implemented")
}
// Compute and send the new configuration for a connection. This is blocking and may be slow
// for large configs. The method will hold a lock on con.pushMutex.
func (s *DiscoveryServer) pushConnection(con *XdsConnection, pushEv *XdsEvent) error {
// TODO: update the service deps based on NetworkScope
if pushEv.edsUpdatedServices != nil {
// Push only EDS. This is indexed already - push immediately
// (may need a throttle)
if len(con.Clusters) > 0 {
if err := s.pushEds(pushEv.push, con, pushEv.edsUpdatedServices); err != nil {
return err
}
}
return nil
}
// Precompute the sidecar scope associated with this proxy if its a sidecar type.
// Saves compute cycles in networking code
if con.modelNode.Type == model.SidecarProxy {
pushEv.push.SetSidecarScope(con.modelNode)
}
adsLog.Infof("Pushing %v", con.ConID)
s.rateLimiter.Wait(context.TODO()) // rate limit the actual push
// Prevent 2 overlapping pushes.
con.pushMutex.Lock()
defer con.pushMutex.Unlock()
defer func() {
n := atomic.AddInt32(pushEv.pending, -1)
if n <= 0 && pushEv.push.End == timeZero {
// Display again the push status
pushEv.push.Mutex.Lock()
pushEv.push.End = time.Now()
pushEv.push.Mutex.Unlock()
proxiesConvergeDelay.Observe(time.Since(pushEv.push.Start).Seconds())
out, _ := pushEv.push.JSON()
adsLog.Infof("Push finished: %v %s",
time.Since(pushEv.push.Start), string(out))
}
}()
// check version, suppress if changed.
currentVersion := versionInfo()
if pushEv.version != currentVersion {
adsLog.Infof("Suppress push for %s at %s, push with newer version %s in progress", con.ConID, pushEv.version, currentVersion)
return nil
}
if con.CDSWatch {
err := s.pushCds(con, pushEv.push, pushEv.version)
if err != nil {
return err
}
}
if len(con.Clusters) > 0 {
err := s.pushEds(pushEv.push, con, nil)
if err != nil {
return err
}
}
if con.LDSWatch {
err := s.pushLds(con, pushEv.push, pushEv.version)
if err != nil {
return err
}
}
if len(con.Routes) > 0 {
err := s.pushRoute(con, pushEv.push)
if err != nil {
return err
}
}
return nil
}
func adsClientCount() int {
var n int
adsClientsMutex.RLock()
n = len(adsClients)
adsClientsMutex.RUnlock()
return n
}
// AdsPushAll is used only by tests (after refactoring)
func AdsPushAll(s *DiscoveryServer) {
s.AdsPushAll(versionInfo(), s.globalPushContext(), true, nil)
}
// AdsPushAll implements old style invalidation, generated when any rule or endpoint changes.
// Primary code path is from v1 discoveryService.clearCache(), which is added as a handler
// to the model ConfigStorageCache and Controller.
func (s *DiscoveryServer) AdsPushAll(version string, push *model.PushContext,
full bool, edsUpdates map[string]struct{}) {
if !full {
s.edsIncremental(version, push, edsUpdates)
return
}
adsLog.Infof("XDS: Pushing %s Services: %d, "+
"ConnectedEndpoints: %d", version,
len(push.Services(nil)), adsClientCount())
monServices.Set(float64(len(push.Services(nil))))
t0 := time.Now()
// First update all cluster load assignments. This is computed for each cluster once per config change
// instead of once per endpoint.
edsClusterMutex.Lock()
// Create a temp map to avoid locking the add/remove
cMap := make(map[string]map[model.Locality]*EdsCluster, len(edsClusters))
for k, v := range edsClusters {
cMap[k] = map[model.Locality]*EdsCluster{}
for locality, edsCluster := range v {
cMap[k][locality] = edsCluster
}
}
edsClusterMutex.Unlock()
// UpdateCluster updates the cluster with a mutex, this code is safe ( but computing
// the update may be duplicated if multiple goroutines compute at the same time).
// In general this code is called from the 'event' callback that is throttled.
for clusterName, edsCluster := range cMap {
if err := s.updateCluster(push, clusterName, edsCluster); err != nil {
adsLog.Errorf("updateCluster failed with clusterName %s", clusterName)
totalXDSInternalErrors.Add(1)
}
}
adsLog.Infof("Cluster init time %v %s", time.Since(t0), version)
s.startPush(version, push, true, nil)
}
// Send a signal to all connections, with a push event.
func (s *DiscoveryServer) startPush(version string, push *model.PushContext, full bool,
edsUpdates map[string]struct{}) {
// Push config changes, iterating over connected envoys. This cover ADS and EDS(0.7), both share
// the same connection table
adsClientsMutex.RLock()
// Create a temp map to avoid locking the add/remove
pending := []*XdsConnection{}
for _, v := range adsClients {
pending = append(pending, v)
}
adsClientsMutex.RUnlock()
// This will trigger recomputing the config for each connected Envoy.
// It will include sending all configs that envoy is listening for, including EDS.
// TODO: get service, serviceinstances, configs once, to avoid repeated redundant calls.
// TODO: indicate the specific events, to only push what changed.
pendingPush := int32(len(pending))
tstart := time.Now()
// Will keep trying to push to sidecars until another push starts.
wg := sync.WaitGroup{}
for {
if len(pending) == 0 {
break
}
// Using non-blocking push has problems if 2 pushes happen too close to each other
client := pending[0]
pending = pending[1:]
wg.Add(1)
s.concurrentPushLimit <- struct{}{}
go func() {
defer func() {
<-s.concurrentPushLimit
wg.Done()
}()
edsOnly := edsUpdates
if full {
edsOnly = nil
}
Retry:
currentVersion := versionInfo()
// Stop attempting to push
if version != currentVersion && full {
adsLog.Infof("PushAll abort %s, push with newer version %s in progress %v", version, currentVersion, time.Since(tstart))
return
}
select {
case client.pushChannel <- &XdsEvent{
push: push,
pending: &pendingPush,
version: version,
edsUpdatedServices: edsOnly,
}:
client.LastPush = time.Now()
client.LastPushFailure = timeZero
case <-client.stream.Context().Done(): // grpc stream was closed
adsLog.Infof("Client closed connection %v", client.ConID)
case <-time.After(PushTimeout):
// This may happen to some clients if the other side is in a bad state and can't receive.
// The tests were catching this - one of the client was not reading.
pushTimeouts.Add(1)
if client.LastPushFailure.IsZero() {
client.LastPushFailure = time.Now()
adsLog.Warnf("Failed to push, client busy %s", client.ConID)
pushErrors.With(prometheus.Labels{"type": "retry"}).Add(1)
} else {
if time.Since(client.LastPushFailure) > 10*time.Second {
adsLog.Warnf("Repeated failure to push %s", client.ConID)
// unfortunately grpc go doesn't allow closing (unblocking) the stream.
pushErrors.With(prometheus.Labels{"type": "unrecoverable"}).Add(1)
pushTimeoutFailures.Add(1)
return
}
}
goto Retry
}
}()
}
wg.Wait()
adsLog.Infof("PushAll done %s %v", version, time.Since(tstart))
}
func (s *DiscoveryServer) addCon(conID string, con *XdsConnection) {
adsClientsMutex.Lock()
defer adsClientsMutex.Unlock()
adsClients[conID] = con
xdsClients.Set(float64(len(adsClients)))
if con.modelNode != nil {
if _, ok := adsSidecarIDConnectionsMap[con.modelNode.ID]; !ok {
adsSidecarIDConnectionsMap[con.modelNode.ID] = map[string]*XdsConnection{conID: con}
} else {
adsSidecarIDConnectionsMap[con.modelNode.ID][conID] = con
}
}
}
func (s *DiscoveryServer) removeCon(conID string, con *XdsConnection) {
adsClientsMutex.Lock()
defer adsClientsMutex.Unlock()
for _, c := range con.Clusters {
s.removeEdsCon(c, conID, con)
}
if _, exist := adsClients[conID]; !exist {
adsLog.Errorf("ADS: Removing connection for non-existing node %v.", conID)
totalXDSInternalErrors.Add(1)
} else {
delete(adsClients, conID)
}
xdsClients.Set(float64(len(adsClients)))
if con.modelNode != nil {
delete(adsSidecarIDConnectionsMap[con.modelNode.ID], conID)
}
}
// Send with timeout
func (conn *XdsConnection) send(res *xdsapi.DiscoveryResponse) error {
done := make(chan error)
// hardcoded for now - not sure if we need a setting
t := time.NewTimer(SendTimeout)
go func() {
err := conn.stream.Send(res)
done <- err
conn.mu.Lock()
if res.Nonce != "" {
switch res.TypeUrl {
case ClusterType:
conn.ClusterNonceSent = res.Nonce
case ListenerType:
conn.ListenerNonceSent = res.Nonce
case RouteType:
conn.RouteNonceSent = res.Nonce
case EndpointType:
conn.EndpointNonceSent = res.Nonce
}
}
if res.TypeUrl == RouteType {
conn.RouteVersionInfoSent = res.VersionInfo
}
conn.mu.Unlock()
}()
select {
case <-t.C:
// TODO: wait for ACK
adsLog.Infof("Timeout writing %s", conn.ConID)
xdsResponseWriteTimeouts.Add(1)
return errors.New("timeout sending")
case err := <-done:
t.Stop()
return err
}
}