core: optimize bulk chat item deletion #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
reviewed
Oct 3, 2022
| withStore' $ \db -> updateContactTs db user ct lastItemTs | ||
| pure (ct :: Contact) {updatedAt = lastItemTs} | ||
| filesInfo <- withStore' $ \db -> getContactFileInfo db user ct | ||
| maxItemTs_ <- withStore' $ \db -> getContactMaxItemTs db user ct |
There was a problem hiding this comment.
This might be better to choose ID for contacts - for example the one that all chat items before this ID are older than specified. This way we will be deleting in the order of the chat, but some older chat items may remain.
epoberezkin
reviewed
Oct 3, 2022
| withStore' $ \db -> updateGroupTs db user gInfo lastItemTs | ||
| pure (gInfo :: GroupInfo) {updatedAt = lastItemTs} | ||
| filesInfo <- withStore' $ \db -> getGroupFileInfo db user gInfo | ||
| maxItemTs_ <- withStore' $ \db -> getGroupMaxItemTs db user gInfo |
There was a problem hiding this comment.
For groups it probably should be a pair of timestamp and chat item ID.
epoberezkin
reviewed
Oct 3, 2022
| SMDRcv -> do | ||
| ft@RcvFileTransfer {cancelled} <- withStore (\db -> getRcvFileTransfer db user fileId) | ||
| unless cancelled $ cancelRcvFileTransfer user ft | ||
| deleteFile :: forall m. ChatMonad m => User -> CIFileInfo -> m () |
There was a problem hiding this comment.
Does it still delete the connection somewhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.