Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: change default of "transfer images faster/inline" to off, mark as BETA #1889

Merged
merged 2 commits into from
Feb 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class AppPreferences(val context: Context) {
val webrtcIceServers = mkStrPreference(SHARED_PREFS_WEBRTC_ICE_SERVERS, null)
val privacyProtectScreen = mkBoolPreference(SHARED_PREFS_PRIVACY_PROTECT_SCREEN, true)
val privacyAcceptImages = mkBoolPreference(SHARED_PREFS_PRIVACY_ACCEPT_IMAGES, true)
val privacyTransferImagesInline = mkBoolPreference(SHARED_PREFS_PRIVACY_TRANSFER_IMAGES_INLINE, true)
val privacyTransferImagesInline = mkBoolPreference(SHARED_PREFS_PRIVACY_TRANSFER_IMAGES_INLINE, false)
val privacyLinkPreviews = mkBoolPreference(SHARED_PREFS_PRIVACY_LINK_PREVIEWS, true)
private val _simplexLinkMode = mkStrPreference(SHARED_PREFS_PRIVACY_SIMPLEX_LINK_MODE, SimplexLinkMode.default.name)
val simplexLinkMode: SharedPreference<SimplexLinkMode> = SharedPreference(
Expand Down
2 changes: 1 addition & 1 deletion apps/android/app/src/main/res/values-cs/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@
<string name="privacy_and_security">Ochrana osobních údajů a zabezpečení</string>
<string name="your_privacy">Vaše soukromí</string>
<string name="protect_app_screen">Ochrana obrazovky aplikace</string>
<string name="transfer_images_faster">Rychlejší přenos obrázků</string>
<string name="transfer_images_faster">Rychlejší přenos obrázků (BETA)</string>
<string name="send_link_previews">Odesílání náhledů odkazů</string>
<string name="full_backup">Zálohování dat aplikace</string>
<string name="confirm_new_passphrase">Confirm new passphrase…</string>
Expand Down
2 changes: 1 addition & 1 deletion apps/android/app/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@
<string name="your_privacy">Meine Privatsphäre</string>
<string name="protect_app_screen">App-Bildschirm schützen</string>
<string name="auto_accept_images">Bilder automatisch akzeptieren</string>
<string name="transfer_images_faster">Bilder schneller übertragen</string>
<string name="transfer_images_faster">Bilder schneller übertragen (BETA)</string>
<string name="send_link_previews">Link-Vorschau senden</string>
<string name="full_backup">App-Datensicherung</string>
<!-- Settings sections -->
Expand Down
2 changes: 1 addition & 1 deletion apps/android/app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@
<string name="privacy_and_security">Vie privée et sécurité</string>
<string name="protect_app_screen">Protéger l\'écran de l\'app</string>
<string name="auto_accept_images">Images auto-acceptées</string>
<string name="transfer_images_faster">Transfert d\'images plus rapide</string>
<string name="transfer_images_faster">Transfert d\'images plus rapide (BETA)</string>
<string name="full_backup">Sauvegarde des données de l\'app</string>
<string name="settings_section_title_you">VOUS</string>
<string name="settings_section_title_help">AIDE</string>
Expand Down
2 changes: 1 addition & 1 deletion apps/android/app/src/main/res/values-it/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@
<string name="settings_section_title_support">SUPPORTA SIMPLEX CHAT</string>
<string name="settings_section_title_themes">TEMI</string>
<string name="delete_chat_profile_action_cannot_be_undone_warning">Questa azione non può essere annullata: il tuo profilo, i contatti, i messaggi e i file andranno persi in modo irreversibile.</string>
<string name="transfer_images_faster">Trasferisci immagini più velocemente</string>
<string name="transfer_images_faster">Trasferisci immagini più velocemente (BETA)</string>
<string name="settings_section_title_you">TU</string>
<string name="your_chat_database">Il tuo database della chat</string>
<string name="your_current_chat_database_will_be_deleted_and_replaced_with_the_imported_one">Il tuo attuale database di chat verrà ELIMINATO e SOSTITUITO con quello importato.
Expand Down
2 changes: 1 addition & 1 deletion apps/android/app/src/main/res/values-ru/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@
<string name="your_privacy">Конфиденциальность</string>
<string name="protect_app_screen">Защитить экран приложения</string>
<string name="auto_accept_images">Автоприем изображений</string>
<string name="transfer_images_faster">Передавать изображения быстрее</string>
<string name="transfer_images_faster">Передавать изображения в том же соединении (БЕТА)</string>
<string name="send_link_previews">Отправлять картинки ссылок</string>
<string name="full_backup">Резервная копия данных</string>
<!-- Settings sections -->
Expand Down
2 changes: 1 addition & 1 deletion apps/android/app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -673,7 +673,7 @@
<string name="your_privacy">Your privacy</string>
<string name="protect_app_screen">Protect app screen</string>
<string name="auto_accept_images">Auto-accept images</string>
<string name="transfer_images_faster">Transfer images faster</string>
<string name="transfer_images_faster">Transfer images inline (BETA)</string>
<string name="send_link_previews">Send link previews</string>
<string name="full_backup">App data backup</string>

Expand Down
4 changes: 2 additions & 2 deletions apps/ios/Shared/Views/UserSettings/PrivacySettings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ struct PrivacySettings: View {
@AppStorage(DEFAULT_PRIVACY_ACCEPT_IMAGES) private var autoAcceptImages = true
@AppStorage(DEFAULT_PRIVACY_LINK_PREVIEWS) private var useLinkPreviews = true
@AppStorage(DEFAULT_DEVELOPER_TOOLS) private var developerTools = false
@AppStorage(GROUP_DEFAULT_PRIVACY_TRANSFER_IMAGES_INLINE, store: groupDefaults) private var transferImagesInline = true
@AppStorage(GROUP_DEFAULT_PRIVACY_TRANSFER_IMAGES_INLINE, store: groupDefaults) private var transferImagesInline = false
@State private var simplexLinkMode = privacySimplexLinkModeDefault.get()
@AppStorage(DEFAULT_PRIVACY_PROTECT_SCREEN) private var protectScreen = false

Expand All @@ -35,7 +35,7 @@ struct PrivacySettings: View {
}
}
settingsRow("photo.on.rectangle") {
Toggle("Transfer images faster", isOn: $transferImagesInline)
Toggle("Transfer images inline (BETA)", isOn: $transferImagesInline)
}
settingsRow("network") {
Toggle("Send link previews", isOn: $useLinkPreviews)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -940,11 +940,6 @@
<target>Dunkel</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Data" xml:space="preserve">
<source>Data</source>
<target>Daten</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Database ID" xml:space="preserve">
<source>Database ID</source>
<target>Datenbank-ID</target>
Expand Down Expand Up @@ -1093,11 +1088,6 @@
<target>Datenbank löschen</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files &amp; media" xml:space="preserve">
<source>Delete files &amp; media</source>
<target>Dateien &amp; Medien löschen</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files and media?" xml:space="preserve">
<source>Delete files and media?</source>
<target>Dateien und Medien löschen?</target>
Expand Down Expand Up @@ -3307,9 +3297,9 @@ Sie werden aufgefordert, die Authentifizierung abzuschließen, bevor diese Funkt
<target>Um die Ende-zu-Ende-Verschlüsselung mit Ihrem Kontakt zu überprüfen, müssen Sie den Sicherheitscode in Ihren Apps vergleichen oder scannen.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transfer images faster" xml:space="preserve">
<source>Transfer images faster</source>
<target>Bilder schneller übertragen</target>
<trans-unit id="Transfer images inline (BETA)" xml:space="preserve">
<source>Transfer images inline (BETA)</source>
<target>Bilder schneller übertragen (BETA)</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transport isolation" xml:space="preserve">
Expand Down Expand Up @@ -3764,11 +3754,6 @@ Bitten Sie Ihren Kontakt darum einen weiteren Verbindungs-Link zu erzeugen, um s
<target>Ihre Chat-Datenbank ist nicht verschlüsselt. Bitte legen Sie ein Passwort fest, um sie zu schützen.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile" xml:space="preserve">
<source>Your chat profile</source>
<target>Mein Chat-Profil</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile will be sent to group members" xml:space="preserve">
<source>Your chat profile will be sent to group members</source>
<target>Ihr Chat-Profil wird an Gruppenmitglieder gesendet</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -940,11 +940,6 @@
<target>Dark</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Data" xml:space="preserve">
<source>Data</source>
<target>Data</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Database ID" xml:space="preserve">
<source>Database ID</source>
<target>Database ID</target>
Expand Down Expand Up @@ -1093,11 +1088,6 @@
<target>Delete database</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files &amp; media" xml:space="preserve">
<source>Delete files &amp; media</source>
<target>Delete files &amp; media</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files and media?" xml:space="preserve">
<source>Delete files and media?</source>
<target>Delete files and media?</target>
Expand Down Expand Up @@ -3307,9 +3297,9 @@ You will be prompted to complete authentication before this feature is enabled.<
<target>To verify end-to-end encryption with your contact compare (or scan) the code on your devices.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transfer images faster" xml:space="preserve">
<source>Transfer images faster</source>
<target>Transfer images faster</target>
<trans-unit id="Transfer images inline (BETA)" xml:space="preserve">
<source>Transfer images inline (BETA)</source>
<target>Transfer images inline (BETA)</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transport isolation" xml:space="preserve">
Expand Down Expand Up @@ -3764,11 +3754,6 @@ To connect, please ask your contact to create another connection link and check
<target>Your chat database is not encrypted - set passphrase to encrypt it.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile" xml:space="preserve">
<source>Your chat profile</source>
<target>Your chat profile</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile will be sent to group members" xml:space="preserve">
<source>Your chat profile will be sent to group members</source>
<target>Your chat profile will be sent to group members</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -939,11 +939,6 @@
<target>Sombre</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Data" xml:space="preserve">
<source>Data</source>
<target>Données</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Database ID" xml:space="preserve">
<source>Database ID</source>
<target>ID de base de données</target>
Expand Down Expand Up @@ -1092,11 +1087,6 @@
<target>Supprimer la base de données</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files &amp; media" xml:space="preserve">
<source>Delete files &amp; media</source>
<target>Supprimer les fichiers et médias</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files and media?" xml:space="preserve">
<source>Delete files and media?</source>
<target>Supprimer les fichiers et médias ?</target>
Expand Down Expand Up @@ -3294,9 +3284,9 @@ Vous serez invité à confirmer l'authentification avant que cette fonction ne s
<target>Pour vérifier le chiffrement de bout en bout avec votre contact, comparez (ou scannez) le code sur vos appareils.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transfer images faster" xml:space="preserve">
<source>Transfer images faster</source>
<target>Transfert d'images plus rapide</target>
<trans-unit id="Transfer images inline (BETA)" xml:space="preserve">
<source>Transfer images inline (BETA)</source>
<target>Transfert d'images plus rapide (BETA)</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transport isolation" xml:space="preserve">
Expand Down Expand Up @@ -3751,11 +3741,6 @@ Pour vous connecter, veuillez demander à votre contact de créer un autre lien
<target>Votre base de données de chat n'est pas chiffrée - définisez une phrase secrète.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile" xml:space="preserve">
<source>Your chat profile</source>
<target>Votre profil de chat</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile will be sent to group members" xml:space="preserve">
<source>Your chat profile will be sent to group members</source>
<target>Votre profil de chat sera envoyé aux membres du groupe</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -940,11 +940,6 @@
<target>Scuro</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Data" xml:space="preserve">
<source>Data</source>
<target>Dati</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Database ID" xml:space="preserve">
<source>Database ID</source>
<target>ID database</target>
Expand Down Expand Up @@ -1093,11 +1088,6 @@
<target>Elimina database</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files &amp; media" xml:space="preserve">
<source>Delete files &amp; media</source>
<target>Elimina file e multimediali</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files and media?" xml:space="preserve">
<source>Delete files and media?</source>
<target>Eliminare i file e i multimediali?</target>
Expand Down Expand Up @@ -3307,9 +3297,9 @@ Ti verrà chiesto di completare l'autenticazione prima di attivare questa funzio
<target>Per verificare la crittografia end-to-end con il tuo contatto, confrontate (o scansionate) il codice sui vostri dispositivi.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transfer images faster" xml:space="preserve">
<source>Transfer images faster</source>
<target>Trasferisci immagini più velocemente</target>
<trans-unit id="Transfer images inline (BETA)" xml:space="preserve">
<source>Transfer images inline (BETA)</source>
<target>Trasferisci immagini più velocemente (BETA)</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transport isolation" xml:space="preserve">
Expand Down Expand Up @@ -3764,11 +3754,6 @@ Per connetterti, chiedi al tuo contatto di creare un altro link di connessione e
<target>Il tuo database della chat non è crittografato: imposta la password per crittografarlo.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile" xml:space="preserve">
<source>Your chat profile</source>
<target>Il tuo profilo di chat</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile will be sent to group members" xml:space="preserve">
<source>Your chat profile will be sent to group members</source>
<target>Il tuo profilo di chat verrà inviato ai membri del gruppo</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -940,11 +940,6 @@
<target>Тёмная</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Data" xml:space="preserve">
<source>Data</source>
<target>Данные</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Database ID" xml:space="preserve">
<source>Database ID</source>
<target>ID базы данных</target>
Expand Down Expand Up @@ -1093,11 +1088,6 @@
<target>Удалить данные чата</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files &amp; media" xml:space="preserve">
<source>Delete files &amp; media</source>
<target>Удалить файлы и медиа</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Delete files and media?" xml:space="preserve">
<source>Delete files and media?</source>
<target>Удалить файлы и медиа?</target>
Expand Down Expand Up @@ -3307,9 +3297,9 @@ You will be prompted to complete authentication before this feature is enabled.<
<target>Чтобы подтвердить end-to-end шифрование с вашим контактом сравните (или сканируйте) код безопасности на ваших устройствах.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transfer images faster" xml:space="preserve">
<source>Transfer images faster</source>
<target>Передавать изображения быстрее</target>
<trans-unit id="Transfer images inline (BETA)" xml:space="preserve">
<source>Transfer images inline (BETA)</source>
<target>Передавать изображения в том же соединении0 (БЕТА)</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Transport isolation" xml:space="preserve">
Expand Down Expand Up @@ -3764,11 +3754,6 @@ To connect, please ask your contact to create another connection link and check
<target>База данных НЕ зашифрована. Установите пароль, чтобы защитить ваши данные.</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile" xml:space="preserve">
<source>Your chat profile</source>
<target>Ваш профиль</target>
<note>No comment provided by engineer.</note>
</trans-unit>
<trans-unit id="Your chat profile will be sent to group members" xml:space="preserve">
<source>Your chat profile will be sent to group members</source>
<target>Ваш профиль чата будет отправлен членам группы</target>
Expand Down
2 changes: 1 addition & 1 deletion apps/ios/SimpleXChat/AppGroup.swift
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public func registerGroupDefaults() {
GROUP_DEFAULT_STORE_DB_PASSPHRASE: true,
GROUP_DEFAULT_INITIAL_RANDOM_DB_PASSPHRASE: false,
GROUP_DEFAULT_PRIVACY_ACCEPT_IMAGES: true,
GROUP_DEFAULT_PRIVACY_TRANSFER_IMAGES_INLINE: true
GROUP_DEFAULT_PRIVACY_TRANSFER_IMAGES_INLINE: false
])
}

Expand Down