Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: optimize group deletion (delays deletion of unused contacts) #2560

Merged
merged 9 commits into from
Jun 12, 2023
Merged

core: optimize group deletion (delays deletion of unused contacts) #2560

merged 9 commits into from
Jun 12, 2023

Conversation

spaced4ndy
Copy link
Contributor

No description provided.

@spaced4ndy spaced4ndy changed the title core: optimize group deletion (wip) core: optimize group deletion (delays deletion of unused contacts) Jun 8, 2023
@spaced4ndy spaced4ndy marked this pull request as ready for review June 8, 2023 16:21
epoberezkin
epoberezkin reviewed Jun 11, 2023
View reviewed changes
src/Simplex/Chat.hs Outdated Show resolved Hide resolved
epoberezkin
epoberezkin reviewed Jun 11, 2023
View reviewed changes
Copy link
Member

@epoberezkin epoberezkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"deleted" can be removed from the type, it will reduce the noice.

Also, so queries in Contacts table don't check "deleted" column.

@spaced4ndy spaced4ndy merged commit 425c7b9 into master Jun 12, 2023
5 of 6 checks passed
@spaced4ndy spaced4ndy deleted the f/optimize-group-deletion branch June 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epoberezkin epoberezkin epoberezkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spaced4ndy @epoberezkin