core: api to create contacts with group members #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
reviewed
Sep 13, 2023
epoberezkin
reviewed
Sep 13, 2023
epoberezkin
reviewed
Sep 13, 2023
epoberezkin
reviewed
Sep 13, 2023
epoberezkin
reviewed
Sep 13, 2023
src/Simplex/Chat.hs
Outdated
| -- check direct messages preference | ||
| -- auto-join / client setting? (new to_join field if auto join is in UI?) | ||
| -- create contact (PendingMemberContact?) | ||
| -- if member already has contact, replace it (to not mix messages from connections) |
There was a problem hiding this comment.
If contact already exists for member receiving XGrpDirectInv (and doesn't exist for sending member), contact reference on member record will be replaced for the receiving member. Otherwise messages from two connections will be mixed in one contact. Or receiving member could prohibit XGrpDirectInv but then initiating member would never be able to connect directly
epoberezkin
reviewed
Sep 13, 2023
epoberezkin
reviewed
Sep 13, 2023
epoberezkin
reviewed
Sep 14, 2023
epoberezkin
reviewed
Sep 14, 2023
epoberezkin
reviewed
Sep 16, 2023
epoberezkin
reviewed
Sep 16, 2023
| @@ -230,6 +230,9 @@ responseToView user_ ChatConfig {logLevel, showReactions, showReceipts, testView | |||
| CRGroupLink u g cReq mRole -> ttyUser u $ groupLink_ "Group link:" g cReq mRole | |||
| CRGroupLinkDeleted u g -> ttyUser u $ viewGroupLinkDeleted g | |||
| CRAcceptingGroupJoinRequest _ g c -> [ttyFullContact c <> ": accepting request to join group " <> ttyGroup' g <> "..."] | |||
| CRNewMemberContact u Contact {localDisplayName = c} g m -> ttyUser u ["contact for member " <> ttyGroup' g <> " " <> ttyMember m <> " prepared, use " <> highlight ("/invite member contact @" <> c <> " <message>") <> " to send invitation"] | |||
| CRNewMemberContactSentInv u _ct g m -> ttyUser u ["sent invitation to connect directly to member " <> ttyGroup' g <> " " <> ttyMember m] | |||
| CRNewMemberContactReceivedInv u ct g m -> ttyUser u [ttyGroup' g <> " " <> ttyMember m <> " is creating direct contact " <> ttyContact' ct <> " with you"] | |||
There was a problem hiding this comment.
I don't think it needs to be shown in terminal when there is a message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.