ui: add missing error types #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaced4ndy
changed the title
spaced4ndy
changed the title
spaced4ndy
commented
Mar 19, 2024
| case INTERNAL | ||
| } | ||
|
|
||
| public enum RCErrorType: Decodable { | ||
| case `internal`(internalErr: String) | ||
| case identity | ||
| case noLocalAddress | ||
| case newController | ||
| case notDiscovered | ||
| case tlsStartFailed |
There was a problem hiding this comment.
tLSStartFailed ?
There was a problem hiding this comment.
leTS not tread that particular path 馃槄
There was a problem hiding this comment.
not about style, I mean that's how it seems it would be encoded
There was a problem hiding this comment.
unless it's renamed in backend from RCETLSStartFailed to RCETlsStartFailed (which is more work)
There was a problem hiding this comment.
so currently it just wouldn't decode
spaced4ndy
force-pushed
the
f/missed-err
branch
from
5e35cb5
to
cd89b4c
Compare
spaced4ndy
commented
Mar 19, 2024
| @@ -5211,6 +5217,8 @@ sealed class RCErrorType { | |||
| @Serializable @SerialName("internal") data class INTERNAL(val internalErr: String): RCErrorType() | |||
| @Serializable @SerialName("identity") object IDENTITY: RCErrorType() | |||
| @Serializable @SerialName("noLocalAddress") object NO_LOCAL_ADDRESS: RCErrorType() | |||
| @Serializable @SerialName("newController") object NEW_CONTROLLER: RCErrorType() | |||
| @Serializable @SerialName("notDiscovered") object NOT_DISCOVERED: RCErrorType() | |||
| @Serializable @SerialName("tlsStartFailed") object TLS_START_FAILED: RCErrorType() | |||
There was a problem hiding this comment.
tLSStartFailed ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.