ios: wallpapers #4304
Merged
ios: wallpapers #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avently
force-pushed
the
av/ios-wallpapers
branch
from
16f5020
to
372c894
Compare
epoberezkin
reviewed
Jun 12, 2024
apps/ios/SimpleXChat/AppGroup.swift
Outdated
| @@ -276,6 +276,68 @@ public class IntDefault: Default<Int> { | |||
| } | |||
| } | |||
|
|
|||
| public class StringDefault: Default<String> { | |||
There was a problem hiding this comment.
don't think we need it - and not in app group anyway - it's a usual string default.
epoberezkin
reviewed
Jun 12, 2024
apps/ios/SimpleXChat/AppGroup.swift
Outdated
| } | ||
| } | ||
|
|
||
| public class GenericDefault<T> { |
There was a problem hiding this comment.
some hammer factory factory factory...
If it's used just for one type, better define it in place, without any abstractions.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.