ios: better scrolling in chat view #4353
Open
+744
−624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitatingpineapple
force-pushed
the
ios-chatview
branch
from
76066ae
to
82adfea
Compare
| @State private var loadingItems = false | ||
| @State private var firstPage = false | ||
| @State private var itemsInView: Set<String> = [] |
There was a problem hiding this comment.
Constantly updating the itemsInView state while scrolling,
will cause the whole ChatView to be re-evaluated every time new chatItem appears
| content() | ||
| .frame(width: 44, height: 44) | ||
| .background(Material.thin) | ||
| .clipShape(Circle()) |
There was a problem hiding this comment.
I'm sneaking in a small visual change here by using a Material to enhance contrast,
when scrolling over messages.
There was a problem hiding this comment.
where is that? screenshot?
There was a problem hiding this comment.
buttom.mp4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.