SMP server information #1072
Merged
SMP server information #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epoberezkin
force-pushed
the
ep/server-info
branch
from
2aa1d53
to
9889493
Compare
dpwiz
reviewed
Mar 27, 2024
* smp-server: serve contact and link pages from static files * generate index * use params from ini * render using ServerInformation * tweak templates * update * fix some html * smp-server: fix layout (#1097) * smp-server: fix layout * port fixes to link page --------- Co-authored-by: Alexander Bondarenko <486682+dpwiz@users.noreply.github.com> * update server information page --------- Co-authored-by: Evgeny Poberezkin <evgeny@poberezkin.com> Co-authored-by: M. Sarmad Qadeer <MSarmadQadeer@gmail.com>
epoberezkin
force-pushed
the
ep/server-info
branch
from
a3e8510
to
5ee167a
Compare
* web: improve server info page design * web: fix font errors & some tags * web: improve contact & invitation page layout and header * update * remove unused files/css * cleanup * fix link page * remove unused font links --------- Co-authored-by: Evgeny Poberezkin <evgeny@poberezkin.com>
dpwiz
reviewed
May 27, 2024
| @@ -303,7 +305,7 @@ smpServerCLI_ generateSite serveStaticFiles cfgPath logPath = | |||
| agreeSecret = True, | |||
| networkConfig = | |||
| defaultNetworkConfig | |||
| { socksProxy = either error id <$> strDecodeIni "PROXY" "socks_proxy" ini, | |||
| { socksProxy = either error id <$!> strDecodeIni "PROXY" "socks_proxy" ini, | |||
There was a problem hiding this comment.
either error id <$!> strDecodeIni is everywhere and continues to spread.
Move to the error/forcing to the function itself (with HasCallStack)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.