database migrations

[epoberezkin]

No description provided.

[spaced4ndy]

not a fan of these up and down migrations due to many reasons:

• have to write two way migrations - writing migrations becomes 2x more prone to error
• migration down deletes from migrations table
• more complex implementation of migration logic
• data is not being migrated down anyway (neither it does up, but this we'd have to support)

I think we should use migrations as a tool for us to upgrade schema one way, rather than for a user to allow having non matching versions of database and application (who'd want it anyway?) - when the mismatch happens due to application version upgrade the application would then read append only migration table and based on the new migrations it has play them out. List of migrations doesn't have to be duplicated in the code, but built from the files in migrations folder. The first migration would be creation of the migrations table

[epoberezkin]

removed down migrations

neither it does up, but this we'd have to support

up migrations have to migrate data, not only schema.

[spaced4ndy]

Cool!

The only thing I question is exposing Migrations.app - this doesn't seem to have any benefit, we could just "call" app directly inside get w/t parameterizing it.