agent: delivery receipts #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaced4ndy
reviewed
Jun 21, 2023
spaced4ndy
reviewed
Jun 21, 2023
spaced4ndy
reviewed
Jun 21, 2023
spaced4ndy
reviewed
Jun 21, 2023
spaced4ndy
reviewed
Jun 21, 2023
spaced4ndy
reviewed
Jul 3, 2023
spaced4ndy
reviewed
Jul 3, 2023
Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com>
spaced4ndy
reviewed
Jul 4, 2023
src/Simplex/Messaging/Agent/Store/SQLite/Migrations/M20230701_delivery_receipts.hs
Outdated
Show resolved
Hide resolved
epoberezkin
force-pushed
the
ep/rfc-delivery-receipts
branch
from
e50f931
to
c1360fa
Compare
spaced4ndy
reviewed
Jul 13, 2023
spaced4ndy
reviewed
Jul 13, 2023
spaced4ndy
reviewed
Jul 13, 2023
Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com>
Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com>
JonathanLorimer
pushed a commit
to JonathanLorimer/simplexmq
that referenced
this pull request
Aug 8, 2023
* rfc: delivery receipts * update doc * update rfc * implementation plan, types, schema * migration, update types * update types * rename migration * export MsgReceiptStatus, JSON encoding * update rfc, schema * correction Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com> * skeleton of the implementation * more implementation (some tests fail) * more code, 1 test fails * fix encoding * refactor * refactor * test, fix * only send receipts in v3+, test * flip condition Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com> * flip condition Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com> * agent version 4 required to send receipts * fix test --------- Co-authored-by: spaced4ndy <8711996+spaced4ndy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.