Docker entrypoint fixes #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, could you rebase your changes against master? After that, I'll make a review. |
Don't Repeat Yourself Set a variable for the full path to the source file. Create the backup path by appending an extension from `date` output. Also fixed quoting and switched to an `if` block. Clean up block level variables.
The previous format discards information about the local time zone.
Now the format always ends in +00:00, and we can ignore that part again.
Present a leading zero before the month: YYYY-0MM-DD Both YYYY-MM-DD and YYYY-DD-MM are used by people and can be confusing in the beginning of the month.
Without avoiding field splitting a password containing a space changes the number of arguments being set.
Make the intentions clear and don't assume the user knows the special cases for when variables won't be extended.
Example:
word=animal
words=mistake
echo "$words vs $word vs ${word}s"
|
@shumvgolove Rebased and I also made similar changes for the new entrypoint file you added. |
shumvgolove
requested changes
May 15, 2023
* switched from long to short option to date for POSIX * docker entrypoint-smp-server: explain date format * docker entrypoint-xftp-server: explain date format
I fixed the case to match the date format letters. Also, use words to explain since I don't want everyone to need to read about date formats to understand.
I was either going to quote the dashes too or stop quoting the colons. Having less quotes was more readable.
This reverts commit ba2a93b.
|
@shumvgolove GitHub did not seem to track this PR state correctly. The date format has been reverted and appropriate comments are included. |
|
Sorry, got a little busy last week. It appears that |
* docker entrypoint-smp-server: remove %F Used part of the explicit ISO 8601 format, provided by the coreutils date invocation guide. * docker entrypoint-xftp-server: remove %F Used part of the explicit ISO 8601 format, provided by the coreutils date invocation guide.
shumvgolove
approved these changes
May 29, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are most of the changes from my previously NACK'd rewrite PR. #746
Capitalized environment variables still needs to be done and the README will need updates for that part.That work was done in #750 instead.