Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest merging with AAR alters APK source file #397

Closed
osbolab opened this issue Jun 23, 2014 · 3 comments
Closed

Manifest merging with AAR alters APK source file #397

osbolab opened this issue Jun 23, 2014 · 3 comments

Comments

@osbolab
Copy link

osbolab commented Jun 23, 2014

See this abandoned issue;

<packaging>apk</packaging>
...
<plugin>
  <groupId>com.jayway.maven.plugins.android.generation2</groupId>
  <artifactId>android-maven-plugin</artifactId>
  <configuration>
    <mergeManifests>true</mergeManifests>
...
<dependency>
  <artifactId>the-library</artifactId>
  <type>aar</type>
</dependency>

$ cp src/main/AndroidManifest.xml original
$ mvn package
$ diff src/main/AndroidManifest.xml original | wc -l
111

Expected output: 0

Plugin is from 51f16d5

Edit: I'm using IDEA 13.1.3, but I'm not using it to build.
apk - aar

@william-ferguson-au
Copy link
Contributor

@matt do you have a project showing the failure?

On Tue, Jun 24, 2014 at 5:02 AM, Matt Barnard notifications@github.com
wrote:

See this abandoned issue
https://code.google.com/p/maven-android-plugin/issues/detail?id=401;

apk
...

com.jayway.maven.plugins.android.generation2
android-maven-plugin

true
...

the-library
aar


$ cp src/main/AndroidManifest.xml original
$ mvn package
$ diff src/main/AndroidManifest.xml original | wc -l
111

Expected output: 0

Plugin is from 51f16d5
51f16d5


Reply to this email directly or view it on GitHub
#397.

@osbolab
Copy link
Author

osbolab commented Jun 24, 2014

Okay, I promise I won't open any more issues like these last two.

sourceManifestFile and androidManifestFile are very much alike to tired eyes.

@osbolab osbolab closed this as completed Jun 24, 2014
@william-ferguson-au
Copy link
Contributor

;) we've all been there

On Tue, Jun 24, 2014 at 10:19 AM, Matt Barnard notifications@github.com
wrote:

Closed #397 #397.


Reply to this email directly or view it on GitHub
#397 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants