-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing in reactor projects so that we can resolve reactor dependencies. #347
Passing in reactor projects so that we can resolve reactor dependencies. #347
Conversation
I see a late night hacking session coming up VERY soon |
@william-ferguson-au is this supposed to also fix the issue I was reporting earlier this week? if so I have to disappoint you that it doesn't :( |
Sebastien, if you mean your comments on pull-request#270 then yes, it most certainly should resolve that issue. If it doesn't can you please raise an issue and include a cut down project showing the failure. |
Or at the very least point me to a cut down project that still displays the On Sun, May 11, 2014 at 6:47 PM, Sebastian Gröbler <notifications@github.com
|
Sure, here you go:
A little background on the above:
The above mentioned steps work with the maven-android-plugin in version 3.8.2 but not in version 3.9.0-rc (including your latest patch). |
Hi Sebastian. I can replicate an error, but it doesn't appear to be And it is orthogonal to this pull request as the viewpagerindicator is not NB It is failing at the connector (ie wagon level) with All the stack is deep within Maven and the dependency resolution process. [ERROR] Failed to execute goal on project tictactoe-app: Could not resolve On Mon, May 12, 2014 at 2:22 AM, Sebastian Gröbler <notifications@github.com
|
Sebastian, I think your problem is one of misconfiguration. Using s3Browser On Mon, May 12, 2014 at 8:09 AM, William Ferguson <
|
Hey William, as I mentioned earlier the whole thing works perfectly with the maven-android-plugin 3.8.2 but not with 3.9.0-rc, so I guess we can rule out any misconfiguration (try it yourself). I am really not very experienced with the internals of maven but have you considered that the wagon stuff might not yet be initialised completely at the point when you try to look up the dependencies? As to your problems accessing the s3 bucket, did you use the following parameters? |
OK, I can confirm that it works with 3.8.2 Can you please raise a separate issue for it. It appears that for whatever And yes, those are the S3 params I used. Still can't retrieve the buckets On Mon, May 12, 2014 at 7:01 PM, Sebastian Gröbler <notifications@github.com
|
NB Manfred, this is not an issue raised with this pull request. On Mon, May 12, 2014 at 8:42 PM, William Ferguson <
|
done see: #350 |
First step failed for me. I was unable to build the resolving-reactor-deps branch of the maven-dependency-tree [INFO] --- maven-invoker-plugin:1.8:integration-test (integration-test) @ maven-dependency-tree --- caused by: [ERROR] Child module /home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/moduleZDepsY of /home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/pom.xml does not exist @ |
Malachi, can you dig a little deeper. It builds fine for me and must have [INFO] --- maven-invoker-plugin:1.8:integration-test (integration-test) @ On Tue, May 13, 2014 at 8:08 AM, Malachi de AElfweald <
|
Case sensitivity issue. renamed: src/it/multi-module-test/ModuleZDepsY -> src/it/multi-module-test/moduleZDepsY |
Argh, thanks. On Tue, May 13, 2014 at 8:29 AM, Malachi de AElfweald <
|
I've pushed the rename changes. On Tue, May 13, 2014 at 8:35 AM, William Ferguson <
|
Passing in reactor projects so that we can resolve reactor dependencies.
This pull causes
The problem here is the version org.apache.maven.shared:maven-dependency-tree:jar:2.2-SNAPSHOT I tried to add a plugin repository into each pom.xml to resolve it:
But in this way it causes another error
Am I using the wrong repository? |
As noted above, until the pull request for maven-dependency-tree is merged you will need to build maven-dependency-tree 2.2-SNAPSHOT from https://github.com/william-ferguson-au/maven-shared/tree/resolving-reactor-deps |
Sorry, my bad. |
That's unfortunately broke |
Should be fixed in master now since we are using a fork of the dependency-tree dependency. |
I believe this finally solves the inability to resolve deps that only exist within the reactor.
NB At the moment it relies on a maven-dependency-tree-2.2-SNAPSHOT which you can build from https://github.com/william-ferguson-au/maven-shared/tree/resolving-reactor-deps
Once I have at least two confirmations that everything is good, I will submit the changes to maven-dep-tree.
I have tested against my projects and against the android-maven-plugin-samples/library-projects. library-projects works fine except there is a proguard issue with action-bar-sherlock which looks like another issue entirely. Hopefully someone who is more awake than me will work out what is wrong.
In order to test you will need to: