Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing in reactor projects so that we can resolve reactor dependencies. #347

Merged
merged 1 commit into from
May 15, 2014
Merged

Passing in reactor projects so that we can resolve reactor dependencies. #347

merged 1 commit into from
May 15, 2014

Conversation

william-ferguson-au
Copy link
Contributor

I believe this finally solves the inability to resolve deps that only exist within the reactor.
NB At the moment it relies on a maven-dependency-tree-2.2-SNAPSHOT which you can build from https://github.com/william-ferguson-au/maven-shared/tree/resolving-reactor-deps

Once I have at least two confirmations that everything is good, I will submit the changes to maven-dep-tree.

I have tested against my projects and against the android-maven-plugin-samples/library-projects. library-projects works fine except there is a proguard issue with action-bar-sherlock which looks like another issue entirely. Hopefully someone who is more awake than me will work out what is wrong.

In order to test you will need to:

  • Build maven-dependency-tree-2.2-SNAPSHOT
  • Build/merge this branch and build android-maven-plugin
  • Delete from your repository any projects that wil be used in your test (before each run).
  • Run your tests.

@mosabua
Copy link
Member

mosabua commented May 9, 2014

I see a late night hacking session coming up VERY soon

@SierraGolf
Copy link
Contributor

@william-ferguson-au is this supposed to also fix the issue I was reporting earlier this week? if so I have to disappoint you that it doesn't :(

@william-ferguson-au
Copy link
Contributor Author

Sebastien, if you mean your comments on pull-request#270 then yes, it most certainly should resolve that issue. If it doesn't can you please raise an issue and include a cut down project showing the failure.

@william-ferguson-au
Copy link
Contributor Author

Or at the very least point me to a cut down project that still displays the
failure.

On Sun, May 11, 2014 at 6:47 PM, Sebastian Gröbler <notifications@github.com

wrote:

@william-ferguson-au https://github.com/william-ferguson-au is this
supposed to also fix the issue I was reporting earlier this week? if so I
have to disappoint you that it doesn't :(


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42765347
.

@SierraGolf
Copy link
Contributor

Sure, here you go:

  1. checkout https://github.com/SierraGolf/maven-android-plugin-samples/tree/sierragolf/apklib-wagon-problem
  2. run rm -r ~/.m2/repository/com/viewpagerindicator (remove of local apklib)
  3. run mvn clean install -Daws.accessKeyId=AKIAJSGSWCG4CN33PJNQ -Daws.secretKey=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 in the tictactoe project

A little background on the above:

  • I added an old version of the view pager indicator as a dependency to the tictactoe project
  • I added the s3 wagon as a build extension to the tictactoe project
  • I added a temporary s3 test bucket as snapshot repository to the tictactoe project

The above mentioned steps work with the maven-android-plugin in version 3.8.2 but not in version 3.9.0-rc (including your latest patch).

@william-ferguson-au
Copy link
Contributor Author

Hi Sebastian. I can replicate an error, but it doesn't appear to be
anything to do with android-maven-plugin.

And it is orthogonal to this pull request as the viewpagerindicator is not
part of the reactor.

NB It is failing at the connector (ie wagon level) with
"No connector available to access repository
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots) of type default using the
available factories WagonRepositoryConnectorFactory"

All the stack is deep within Maven and the dependency resolution process.

[ERROR] Failed to execute goal on project tictactoe-app: Could not resolve
dependencies for project
com.simpligility.android.tictactoe:tictactoe-app:apk:1.0.0-SNAPSHOT: Failed
to collect dependencies at com.viewpagerindi
cator:viewpagerindicator:apklib:2.4.2-SNAPSHOT: Failed to read artifact
descriptor for
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT: Failure to
transfer com.viewpagerindicator:viewpagerindicator:pom:2.
4.2-SNAPSHOT from s3://codereligion-mvn-repository/snapshots was cached in
the local repository, resolution will not be reattempted until the update
interval of codereligion-mvn-repository-snapshots has elapsed or update
s are forced. Original error: Could not transfer artifact
com.viewpagerindicator:viewpagerindicator:pom:2.4.2-SNAPSHOT from/to
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots): No connec
tor available to access repository codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots) of type default using the
available factories WagonRepositoryConnectorFactory -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal on project tictactoe-app: Could not resolve dependencies for project
com.simpligility.android.tictactoe:tictactoe-app:apk:1.0.0-SNAPSHOT: Fai
led to collect dependencies at
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:220)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:127)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:257)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:200)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.project.DependencyResolutionException: Could
not resolve dependencies for project
com.simpligility.android.tictactoe:tictactoe-app:apk:1.0.0-SNAPSHOT: Failed
to collect dependencies at com.vie
wpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:167)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:195)
... 22 more
Caused by: org.eclipse.aether.collection.DependencyCollectionException:
Failed to collect dependencies at
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:292)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:317)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:159)
... 23 more
Caused by: org.eclipse.aether.resolution.ArtifactDescriptorException:
Failed to read artifact descriptor for
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:335)
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:217)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:461)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:261)
... 25 more
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException:
Failure to transfer
com.viewpagerindicator:viewpagerindicator:pom:2.4.2-SNAPSHOT from
s3://codereligion-mvn-repository/snapshots was cached in the loc
al repository, resolution will not be reattempted until the update interval
of codereligion-mvn-repository-snapshots has elapsed or updates are forced.
Original error: Could not transfer artifact com.viewpagerindicator:v
iewpagerindicator:pom:2.4.2-SNAPSHOT from/to
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots): No connector available to
access repository codereligion-mvn-repository-snapshots (s3://cod
ereligion-mvn-repository/snapshots) of type default using the available
factories WagonRepositoryConnectorFactory
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:459)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:262)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:239)
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:320)
... 28 more
Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Failure
to transfer com.viewpagerindicator:viewpagerindicator:pom:2.4.2-SNAPSHOT
from s3://codereligion-mvn-repository/snapshots was cached in the local r
epository, resolution will not be reattempted until the update interval of
codereligion-mvn-repository-snapshots has elapsed or updates are forced.
Original error: Could not transfer artifact com.viewpagerindicator:viewp
agerindicator:pom:2.4.2-SNAPSHOT from/to
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots): No connector available to
access repository codereligion-mvn-repository-snapshots (s3://coderel
igion-mvn-repository/snapshots) of type default using the available
factories WagonRepositoryConnectorFactory
at
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.newException(DefaultUpdateCheckManager.java:239)
at
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkArtifact(DefaultUpdateCheckManager.java:177)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.gatherDownloads(DefaultArtifactResolver.java:599)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:518)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:436)

On Mon, May 12, 2014 at 2:22 AM, Sebastian Gröbler <notifications@github.com

wrote:

Sure, here you go:

  1. checkout
    https://github.com/SierraGolf/maven-android-plugin-samples/tree/sierragolf/apklib-wagon-problem
  2. run rm -r ~/.m2/repository/com/viewpagerindicator (remove of local
    apklib)
  3. run mvn clean install -Daws.accessKeyId=AKIAJSGSWCG4CN33PJNQ
    -Daws.secretKey=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 in the
    tictactoe project

A little background on the above:

  • I added an old version of the view pager indicator as a dependency
    to the tictactoe project
  • I added the s3 wagon as a build extension to the tictactoe project
  • I added a temporary s3 test bucket as snapshot repository to the
    tictactoe project

The above mentioned steps work with the maven-android-plugin in version
3.8.2 but not in version 3.9.0-rc (including your latest patch).


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42775044
.

@william-ferguson-au
Copy link
Contributor Author

Sebastian, I think your problem is one of misconfiguration. Using s3Browser
I can't see any buckets for those credentials. I keep getting "Accessed
denied".

On Mon, May 12, 2014 at 8:09 AM, William Ferguson <
william.ferguson@xandar.com.au> wrote:

Hi Sebastian. I can replicate an error, but it doesn't appear to be
anything to do with android-maven-plugin.

And it is orthogonal to this pull request as the viewpagerindicator is not
part of the reactor.

NB It is failing at the connector (ie wagon level) with
"No connector available to access repository
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots) of type default using the
available factories WagonRepositoryConnectorFactory"

All the stack is deep within Maven and the dependency resolution process.

[ERROR] Failed to execute goal on project tictactoe-app: Could not resolve
dependencies for project
com.simpligility.android.tictactoe:tictactoe-app:apk:1.0.0-SNAPSHOT: Failed
to collect dependencies at com.viewpagerindi
cator:viewpagerindicator:apklib:2.4.2-SNAPSHOT: Failed to read artifact
descriptor for
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT: Failure to
transfer com.viewpagerindicator:viewpagerindicator:pom:2.
4.2-SNAPSHOT from s3://codereligion-mvn-repository/snapshots was cached in
the local repository, resolution will not be reattempted until the update
interval of codereligion-mvn-repository-snapshots has elapsed or update
s are forced. Original error: Could not transfer artifact
com.viewpagerindicator:viewpagerindicator:pom:2.4.2-SNAPSHOT from/to
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots): No connec
tor available to access repository codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots) of type default using the
available factories WagonRepositoryConnectorFactory -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal on project tictactoe-app: Could not resolve dependencies for project
com.simpligility.android.tictactoe:tictactoe-app:apk:1.0.0-SNAPSHOT: Fai
led to collect dependencies at
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:220)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies(LifecycleDependencyResolver.java:127)
at
org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved(MojoExecutor.java:257)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:200)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.project.DependencyResolutionException: Could
not resolve dependencies for project
com.simpligility.android.tictactoe:tictactoe-app:apk:1.0.0-SNAPSHOT: Failed
to collect dependencies at com.vie
wpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:167)
at
org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies(LifecycleDependencyResolver.java:195)
... 22 more
Caused by: org.eclipse.aether.collection.DependencyCollectionException:
Failed to collect dependencies at
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:292)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies(DefaultRepositorySystem.java:317)
at
org.apache.maven.project.DefaultProjectDependenciesResolver.resolve(DefaultProjectDependenciesResolver.java:159)
... 23 more
Caused by: org.eclipse.aether.resolution.ArtifactDescriptorException:
Failed to read artifact descriptor for
com.viewpagerindicator:viewpagerindicator:apklib:2.4.2-SNAPSHOT
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:335)
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:217)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.process(DefaultDependencyCollector.java:461)
at
org.eclipse.aether.internal.impl.DefaultDependencyCollector.collectDependencies(DefaultDependencyCollector.java:261)
... 25 more
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException:
Failure to transfer
com.viewpagerindicator:viewpagerindicator:pom:2.4.2-SNAPSHOT from
s3://codereligion-mvn-repository/snapshots was cached in the loc
al repository, resolution will not be reattempted until the update
interval of codereligion-mvn-repository-snapshots has elapsed or updates
are forced. Original error: Could not transfer artifact
com.viewpagerindicator:v
iewpagerindicator:pom:2.4.2-SNAPSHOT from/to
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots): No connector available to
access repository codereligion-mvn-repository-snapshots (s3://cod
ereligion-mvn-repository/snapshots) of type default using the available
factories WagonRepositoryConnectorFactory
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:459)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:262)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:239)
at
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:320)
... 28 more
Caused by: org.eclipse.aether.transfer.ArtifactTransferException: Failure
to transfer com.viewpagerindicator:viewpagerindicator:pom:2.4.2-SNAPSHOT
from s3://codereligion-mvn-repository/snapshots was cached in the local r
epository, resolution will not be reattempted until the update interval of
codereligion-mvn-repository-snapshots has elapsed or updates are forced.
Original error: Could not transfer artifact com.viewpagerindicator:viewp
agerindicator:pom:2.4.2-SNAPSHOT from/to
codereligion-mvn-repository-snapshots
(s3://codereligion-mvn-repository/snapshots): No connector available to
access repository codereligion-mvn-repository-snapshots (s3://coderel
igion-mvn-repository/snapshots) of type default using the available
factories WagonRepositoryConnectorFactory
at
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.newException(DefaultUpdateCheckManager.java:239)
at
org.eclipse.aether.internal.impl.DefaultUpdateCheckManager.checkArtifact(DefaultUpdateCheckManager.java:177)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.gatherDownloads(DefaultArtifactResolver.java:599)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:518)
at
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:436)

On Mon, May 12, 2014 at 2:22 AM, Sebastian Gröbler <
notifications@github.com> wrote:

Sure, here you go:

  1. checkout
    https://github.com/SierraGolf/maven-android-plugin-samples/tree/sierragolf/apklib-wagon-problem
  2. run rm -r ~/.m2/repository/com/viewpagerindicator (remove of local
    apklib)
  3. run mvn clean install -Daws.accessKeyId=AKIAJSGSWCG4CN33PJNQ
    -Daws.secretKey=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 in the
    tictactoe project

A little background on the above:

  • I added an old version of the view pager indicator as a dependency
    to the tictactoe project
  • I added the s3 wagon as a build extension to the tictactoe project
  • I added a temporary s3 test bucket as snapshot repository to the
    tictactoe project

The above mentioned steps work with the maven-android-plugin in version
3.8.2 but not in version 3.9.0-rc (including your latest patch).


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42775044
.

@SierraGolf
Copy link
Contributor

Hey William,

as I mentioned earlier the whole thing works perfectly with the maven-android-plugin 3.8.2 but not with 3.9.0-rc, so I guess we can rule out any misconfiguration (try it yourself).

I am really not very experienced with the internals of maven but have you considered that the wagon stuff might not yet be initialised completely at the point when you try to look up the dependencies?

As to your problems accessing the s3 bucket, did you use the following parameters?
bucket: codereligion-mvn-repository
username: AKIAJSGSWCG4CN33PJNQ
password: 87Bxjn9iGJpXzLQY/FvDi0BSLwE30MiF9txtJMSR

@william-ferguson-au
Copy link
Contributor Author

OK, I can confirm that it works with 3.8.2

Can you please raise a separate issue for it. It appears that for whatever
reason the wagon is either not accessible or not yet configured
when AbstractMavenLifecycleParticipant is called. And an attempt to resolve
the s3 deps then vetos later resolution. I think this is an issue with
Maven. By the time the AbstractMavenLifecycleParticipant is called all
config should be available.

And yes, those are the S3 params I used. Still can't retrieve the buckets
using the S3Browser.

On Mon, May 12, 2014 at 7:01 PM, Sebastian Gröbler <notifications@github.com

wrote:

Hey William,

as I mentioned earlier the whole thing works perfectly with the
maven-android-plugin 3.8.2 but not with 3.9.0-rc, so I guess we can rule
out any misconfiguration (try it yourself).

I am really not very experienced with the internals of maven but have you
considered that the wagon stuff might not yet be initialised completely at
the point when you try to look up the dependencies?

As to your problems accessing the s3 bucket, did you use the following
parameters?
bucket: codereligion-mvn-repository
username: AKIAJSGSWCG4CN33PJNQ
password: 87Bxjn9iGJpXzLQY/FvDi0BSLwE30MiF9txtJMSR


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42809732
.

@william-ferguson-au
Copy link
Contributor Author

NB Manfred, this is not an issue raised with this pull request.

On Mon, May 12, 2014 at 8:42 PM, William Ferguson <
william.ferguson@xandar.com.au> wrote:

OK, I can confirm that it works with 3.8.2

Can you please raise a separate issue for it. It appears that for whatever
reason the wagon is either not accessible or not yet configured
when AbstractMavenLifecycleParticipant is called. And an attempt to resolve
the s3 deps then vetos later resolution. I think this is an issue with
Maven. By the time the AbstractMavenLifecycleParticipant is called all
config should be available.

And yes, those are the S3 params I used. Still can't retrieve the buckets
using the S3Browser.

On Mon, May 12, 2014 at 7:01 PM, Sebastian Gröbler <
notifications@github.com> wrote:

Hey William,

as I mentioned earlier the whole thing works perfectly with the
maven-android-plugin 3.8.2 but not with 3.9.0-rc, so I guess we can rule
out any misconfiguration (try it yourself).

I am really not very experienced with the internals of maven but have you
considered that the wagon stuff might not yet be initialised completely at
the point when you try to look up the dependencies?

As to your problems accessing the s3 bucket, did you use the following
parameters?
bucket: codereligion-mvn-repository
username: AKIAJSGSWCG4CN33PJNQ
password: 87Bxjn9iGJpXzLQY/FvDi0BSLwE30MiF9txtJMSR


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42809732
.

@SierraGolf
Copy link
Contributor

done see: #350

@malachid
Copy link
Contributor

First step failed for me. I was unable to build the resolving-reactor-deps branch of the maven-dependency-tree

[INFO] --- maven-invoker-plugin:1.8:integration-test (integration-test) @ maven-dependency-tree ---
[INFO] Building: multi-module-plugin/pom.xml
[INFO] ..SUCCESS (5.7 s)
[INFO] Building: mshared-167/pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (41.4 s)
[INFO] Building: multi-module-test/pom.xml
[INFO] ..FAILED (1.2 s)
[INFO] The build exited with code 1. See /home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/build.log for details.
[INFO] Building: maven-version/pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (5.4 s)
[INFO]
[INFO] --- maven-invoker-plugin:1.8:verify (integration-test) @ maven-dependency-tree ---
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO] Passed: 3, Failed: 1, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] * multi-module-test/pom.xml
[INFO] -------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

caused by:

[ERROR] Child module /home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/moduleZDepsY of /home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/pom.xml does not exist @

@william-ferguson-au
Copy link
Contributor Author

Malachi, can you dig a little deeper. It builds fine for me and must have
done for Sebastian too.
For reference I have built against Maven 3.2.1 (log below) and 3.0.4

[INFO] --- maven-invoker-plugin:1.8:integration-test (integration-test) @
maven-dependency-tree ---
[INFO] Building: maven-version\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (5.1 s)
[INFO] Building: mshared-167\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (13.2 s)
[INFO] Building: multi-module-plugin\pom.xml
[INFO] ..SUCCESS (5.6 s)
[INFO] Building: multi-module-test\pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (3.7 s)
[INFO]

On Tue, May 13, 2014 at 8:08 AM, Malachi de AElfweald <
notifications@github.com> wrote:

First step failed for me. I was unable to build the resolving-reactor-deps
branch of the maven-dependency-tree

[INFO] --- maven-invoker-plugin:1.8:integration-test (integration-test) @
maven-dependency-tree ---
[INFO] Building: multi-module-plugin/pom.xml
[INFO] ..SUCCESS (5.7 s)
[INFO] Building: mshared-167/pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (41.4 s)
[INFO] Building: multi-module-test/pom.xml
[INFO] ..FAILED (1.2 s)
[INFO] The build exited with code 1. See
/home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/build.log
for details.
[INFO] Building: maven-version/pom.xml
[INFO] run script verify.bsh
[INFO] ..SUCCESS (5.4 s)
[INFO]
[INFO] --- maven-invoker-plugin:1.8:verify (integration-test) @
maven-dependency-tree ---
[INFO] -------------------------------------------------
[INFO] Build Summary:
[INFO] Passed: 3, Failed: 1, Errors: 0, Skipped: 0
[INFO] -------------------------------------------------
[ERROR] The following builds failed:
[ERROR] * multi-module-test/pom.xml
[INFO] -------------------------------------------------

[INFO]

[INFO] BUILD FAILURE

[INFO]

caused by:

[ERROR] Child module
/home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/moduleZDepsY
of
/home/malachi/work/public/jayway/maven-shared/maven-dependency-tree/target/it/multi-module-test/pom.xml
does not exist @


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42894887
.

@malachid
Copy link
Contributor

Case sensitivity issue.
This fixes it:

renamed: src/it/multi-module-test/ModuleZDepsY -> src/it/multi-module-test/moduleZDepsY

@william-ferguson-au
Copy link
Contributor Author

Argh, thanks.

On Tue, May 13, 2014 at 8:29 AM, Malachi de AElfweald <
notifications@github.com> wrote:

Case sensitivity issue.
This fixes it:

renamed: src/it/multi-module-test/ModuleZDepsY/pom.xml ->
src/it/multi-module-test/moduleZDepsY/pom.xml


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42896643
.

@william-ferguson-au
Copy link
Contributor Author

I've pushed the rename changes.

On Tue, May 13, 2014 at 8:35 AM, William Ferguson <
william.ferguson@xandar.com.au> wrote:

Argh, thanks.

On Tue, May 13, 2014 at 8:29 AM, Malachi de AElfweald <
notifications@github.com> wrote:

Case sensitivity issue.
This fixes it:

renamed: src/it/multi-module-test/ModuleZDepsY/pom.xml ->
src/it/multi-module-test/moduleZDepsY/pom.xml


Reply to this email directly or view it on GitHubhttps://github.com//pull/347#issuecomment-42896643
.

mosabua added a commit that referenced this pull request May 15, 2014
Passing in reactor projects so that we can resolve reactor dependencies.
@mosabua mosabua merged commit a63b4a2 into simpligility:master May 15, 2014
@Gnafu
Copy link

Gnafu commented May 17, 2014

This pull causes

[ERROR]     Unresolveable build extension: Plugin com.jayway.maven.plugins.android.generation2:android-maven-plugin:3.9.0-SNAPSHOT or one of its dependencies could not be resolved: Failure to find org.apache.maven.shared:maven-dependency-tree:jar:2.2-SNAPSHOT in http://snapshots.repository.codehaus.org/ was cached in the local repository, resolution will not be reattempted until the update interval of codehaus-snapshot-plugins has elapsed or updates are forced -> [Help 2]
[ERROR]     Unknown packaging: apklib @ line 7, column 14

The problem here is the version

org.apache.maven.shared:maven-dependency-tree:jar:2.2-SNAPSHOT

I tried to add a plugin repository into each pom.xml to resolve it:

<pluginRepositories>
    <pluginRepository>
        <id>oss.sonatype.org-jayway-snapshots</id>
        <name>Jayway OpenSource SNAPSHOTs on Sonatype.org</name>
        <url>http://oss.sonatype.org/content/repositories/jayway-snapshots/</url>
        <snapshots>
            <enabled>true</enabled>
        </snapshots>
    </pluginRepository>
    <pluginRepository>
        <id>apache.snapshots</id>
        <name>Apache Development Snapshot Repository</name>
        <url>https://repository.apache.org/content/repositories/snapshots/</url>
        <releases>
        <enabled>false</enabled>
        </releases>
        <snapshots>
            <enabled>true</enabled>
        </snapshots>
    </pluginRepository>
</pluginRepositories> 

But in this way it causes another error

Downloaded: https://repository.apache.org/content/repositories/snapshots/org/apache/maven/shared/maven-dependency-tree/2.2-SNAPSHOT/maven-dependency-tree-2.2-20140516.190829-98.jar (59 KB at 31.1 KB/sec)

---------------------------------------------------
constituent[0]: file:/A:/maven/maven-3.2.1/lib/aether-api-0.9.0.M2.jar
constituent[1]: file:/A:/maven/maven-3.2.1/lib/aether-connector-wagon-0.9.0.M2.jar
constituent[2]: file:/A:/maven/maven-3.2.1/lib/aether-impl-0.9.0.M2.jar
constituent[3]: file:/A:/maven/maven-3.2.1/lib/aether-spi-0.9.0.M2.jar
constituent[4]: file:/A:/maven/maven-3.2.1/lib/aether-util-0.9.0.M2.jar
constituent[5]: file:/A:/maven/maven-3.2.1/lib/aopalliance-1.0.jar
constituent[6]: file:/A:/maven/maven-3.2.1/lib/cdi-api-1.0.jar
constituent[7]: file:/A:/maven/maven-3.2.1/lib/commons-cli-1.2.jar
constituent[8]: file:/A:/maven/maven-3.2.1/lib/commons-io-2.2.jar
constituent[9]: file:/A:/maven/maven-3.2.1/lib/commons-lang-2.6.jar
constituent[10]: file:/A:/maven/maven-3.2.1/lib/guava-14.0.1.jar
constituent[11]: file:/A:/maven/maven-3.2.1/lib/javax.inject-1.jar
constituent[12]: file:/A:/maven/maven-3.2.1/lib/jsoup-1.7.2.jar
constituent[13]: file:/A:/maven/maven-3.2.1/lib/jsr250-api-1.0.jar
constituent[14]: file:/A:/maven/maven-3.2.1/lib/maven-aether-provider-3.2.1.jar
constituent[15]: file:/A:/maven/maven-3.2.1/lib/maven-artifact-3.2.1.jar
constituent[16]: file:/A:/maven/maven-3.2.1/lib/maven-compat-3.2.1.jar
constituent[17]: file:/A:/maven/maven-3.2.1/lib/maven-core-3.2.1.jar
constituent[18]: file:/A:/maven/maven-3.2.1/lib/maven-embedder-3.2.1.jar
constituent[19]: file:/A:/maven/maven-3.2.1/lib/maven-model-3.2.1.jar
constituent[20]: file:/A:/maven/maven-3.2.1/lib/maven-model-builder-3.2.1.jar
constituent[21]: file:/A:/maven/maven-3.2.1/lib/maven-plugin-api-3.2.1.jar
constituent[22]: file:/A:/maven/maven-3.2.1/lib/maven-repository-metadata-3.2.1.jar
constituent[23]: file:/A:/maven/maven-3.2.1/lib/maven-settings-3.2.1.jar
constituent[24]: file:/A:/maven/maven-3.2.1/lib/maven-settings-builder-3.2.1.jar
constituent[25]: file:/A:/maven/maven-3.2.1/lib/org.eclipse.sisu.inject-0.0.0.M5.jar
constituent[26]: file:/A:/maven/maven-3.2.1/lib/org.eclipse.sisu.plexus-0.0.0.M5.jar
constituent[27]: file:/A:/maven/maven-3.2.1/lib/plexus-cipher-1.7.jar
constituent[28]: file:/A:/maven/maven-3.2.1/lib/plexus-component-annotations-1.5.5.jar
constituent[29]: file:/A:/maven/maven-3.2.1/lib/plexus-interpolation-1.19.jar
constituent[30]: file:/A:/maven/maven-3.2.1/lib/plexus-sec-dispatcher-1.3.jar
constituent[31]: file:/A:/maven/maven-3.2.1/lib/plexus-utils-3.0.17.jar
constituent[32]: file:/A:/maven/maven-3.2.1/lib/sisu-guice-3.1.3-no_aop.jar
constituent[33]: file:/A:/maven/maven-3.2.1/lib/slf4j-api-1.7.5.jar
constituent[34]: file:/A:/maven/maven-3.2.1/lib/slf4j-simple-1.7.5.jar
constituent[35]: file:/A:/maven/maven-3.2.1/lib/wagon-file-2.6.jar
constituent[36]: file:/A:/maven/maven-3.2.1/lib/wagon-http-2.6-shaded.jar
constituent[37]: file:/A:/maven/maven-3.2.1/lib/wagon-http-shared-2.6.jar
constituent[38]: file:/A:/maven/maven-3.2.1/lib/wagon-provider-api-2.6.jar
constituent[39]: file:/A:/maven/maven-3.2.1/conf/logging/

---------------------------------------------------
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/maven/shared/dependency/graph/ProjectReferenceKeyGenerator
        at com.jayway.maven.plugins.android.common.DependencyResolver.getReactorProjects(DependencyResolver.java:68)
        at com.jayway.maven.plugins.android.common.DependencyResolver.getProjectDependenciesFor(DependencyResolver.java:47)
        at com.jayway.maven.plugins.android.phase_prebuild.ClasspathModifierLifecycleParticipant.afterProjectsRead(ClasspathModifierLifecycleParticipant.java:78)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:317)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: java.lang.ClassNotFoundException: org.apache.maven.shared.dependency.graph.ProjectReferenceKeyGenerator
        at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
        at org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259)
        at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235)
        at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227)
        ... 16 more

Am I using the wrong repository?
Do you have any suggestions?
Thank you very much

@william-ferguson-au
Copy link
Contributor Author

As noted above, until the pull request for maven-dependency-tree is merged you will need to build maven-dependency-tree 2.2-SNAPSHOT from https://github.com/william-ferguson-au/maven-shared/tree/resolving-reactor-deps

@william-ferguson-au william-ferguson-au deleted the resolving-reactor-deps branch May 17, 2014 09:36
@Gnafu
Copy link

Gnafu commented May 17, 2014

Sorry, my bad.
Any way, building the maven-dependency-tree-2.2-SNAPSHOT from the branch I had to turn off the tests, due tue a turkish language test failing.
After that, it works.
Thank you very much

@a-chernykh
Copy link

That's unfortunately broke 3.9.0-SNAPSHOT for me with the error mentioned by @Gnafu I understand that 2.2-SNAPSHOT should be built manually, but just wanted to point this out.

@mosabua
Copy link
Member

mosabua commented May 27, 2014

Should be fixed in master now since we are using a fork of the dependency-tree dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants