Second solution for manifestFile params #508 #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shusshu
force-pushed
the
issue-manifest-param-2
branch
from
c718b54
to
22d97d0
Compare
|
Discussion in #508 concluded that we want to go with this approach. |
Shusshu
added a commit
that referenced
this pull request
Dec 29, 2014
Second solution for manifestFile params #508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #541
we remove sourceManifestFile, make the default location of androidManifestFile to src/main/AndroidManifest.xml and make the default location of finalManifestFile to the build directory and use that variable in all mojos.... in that case we would break the config for people using sourceManifest & updatedManifest which is fine I guess.
This would be valid for an AMP release 4.1 or 4.5 as it breaks configuration for people using sourceManifestFile and/or updatedManifestFile