NDK: set APP_BUILD_SCRIPT for makefile parameter instead of -f #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added an integration test project. I just copied the simple so project and renamed the <makefile>src/Android.mk</makefile>
<applicationMakefile>src/Application.mk</applicationMakefile> |
kedzie
force-pushed
the
ndk_makefile
branch
from
e6e337a
to
89193bc
Compare
|
Can you pull this over to the NDK plugin... the NDK functionality will be removed on this plugin soon so I would rather pull that in on the other plugin .. right @JohanLindquist ? |
|
that is correct |
kedzie
force-pushed
the
ndk_makefile
branch
from
89193bc
to
aa937f9
Compare
-added integration test project -add NDK_OUT/NDK_LIBS_OUT parameters to create build output under target folder instead of root folder then moving it.
kedzie
force-pushed
the
ndk_makefile
branch
from
aa937f9
to
1db4341
Compare
|
Oh I didn't realize that was happening.. I can move it. I also added a patch which makes the output directly under the |
|
I created a new PR simpligility/android-ndk-maven-plugin#12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
makefilendk goal parameter doesn't work. It adds a-f <makefile>to thendk-buildcommandline. That works for normalmakebut forndk-buildit should be settingAPP_BUILD_SCRIPT=<makefile>instead. This is what this fix is doing.