Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added testFailSafe option #688

Merged
merged 1 commit into from
Jan 19, 2016
Merged

added testFailSafe option #688

merged 1 commit into from
Jan 19, 2016

Conversation

kedzie
Copy link
Contributor

@kedzie kedzie commented Oct 16, 2015

so postIntegrationTest phase executes even if the tests failed.

@kedzie
Copy link
Contributor Author

kedzie commented Nov 7, 2015

@mosabua any interest in this? I think it is pretty valuable...

@kedzie
Copy link
Contributor Author

kedzie commented Nov 16, 2015

@psorobka any interest in this? I think it is valuable...

@kedzie
Copy link
Contributor Author

kedzie commented Dec 17, 2015

@mosabua @psorobka anyone out there? I think it makes sense to execute postIntegration phase even if tests fail, for cleanup tasks....

@mosabua
Copy link
Member

mosabua commented Dec 17, 2015

HI @kedzie ... I am extremely busy but I am trying to get all changes merged and a new release out asap. I am hoping before xmas..

mosabua added a commit that referenced this pull request Jan 19, 2016
added testFailSafe option
@mosabua mosabua merged commit 4f37237 into simpligility:master Jan 19, 2016
@mpkorstanje
Copy link

@kedzie what is the reason for setting the default value of testFailSafe to to true?

This makes broken builds pass which is contrary to the expectations of a maven plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants