Accept 202 http status code (instead throwing exception). #102
Conversation
… is used by WCF IsOneWay operations
|
That sounds fair. Checking the OkHttp3 library, a response is counted as a success if the response is:
Do you think you could change the status check to that? |
| if(is!=null) | ||
| { | ||
| parseResponse(envelope, is,retHeaders); | ||
| } |
|
To change success condition to code >= 200 && code < 300 we need to make a bigger investigation. So as a safer solution I would merge the current pull request and later if we ensure that we can use your condition, then we will create a new pull request. We have to check for null becaues during my test when WCF service returns from IsOneWay method, then response length was 0 and the response stream was null. Which of course throws exception in parseResponse method. |
|
@robocik Ah right. That makes sense. Thanks for explaining :) |
|
Could add some changelog entry and if necessary some documentation? |
|
@mosabua What changes would we like to be applied? The ability to accept status code 202 as well or any code which is |
|
If you mean adding the broader status check and adding documentation surrounding that then yes, that's fine with me. |
This status is used by WCF IsOneWay operations