Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix with Python 3.10 (changed exception messages) #158

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

sbraz
Copy link
Contributor

@sbraz sbraz commented Aug 21, 2021

Hi,
Tests need a few small adjustments to pass with Python 3.10.

I guess you could add Python 3.10 it to your CI (and make it non-fatal) but I don't know how Circle CI works so I did not attempt to do it.

@cjw296
Copy link
Member

cjw296 commented Aug 21, 2021

Fantastic, thanks!

@cjw296 cjw296 merged commit 70a9e28 into simplistix:master Aug 21, 2021
cjw296 added a commit that referenced this pull request Aug 21, 2021
This reverts commit 70a9e28, reversing
changes made to 01a4f92.
@cjw296
Copy link
Member

cjw296 commented Aug 21, 2021

@sbraz - apologies, but I've had to revert this as CircleCI aren't ready for Python 3.10 yet:
CircleCI-Public/cimg-python#91

@sbraz
Copy link
Contributor Author

sbraz commented Aug 21, 2021

Hi @cjw296
I have tested 3.8, 3.9 and 3.10 on Gentoo and backported the patch there. I can understand reverting the attempt to add 3.10 CI but couldn't we keep this patch?

@cjw296
Copy link
Member

cjw296 commented Aug 21, 2021

I'm afraid not: I operate a "100% code coverage" policy on this repo, which is why your PR failed its tests.
I shouldn't have merged, but I didn't realise CircleCI had dropped support for pre-releases of Python.

Feel free to signal boost this tweet if you'd like to see this resolved sooner: https://twitter.com/chriswithers13/status/1429163506142781444

@sbraz
Copy link
Contributor Author

sbraz commented Aug 21, 2021

OK I understand, can we at least open an issue or something to keep track of the status of Python 3.10 support?

@cjw296
Copy link
Member

cjw296 commented Aug 24, 2021

@sbraz - what would be great is if you could submit those patches as new PR.
Apologies, I know it's duplicate work, but I figure it might be easier than trying to work out how to resurrect this one!

@cjw296
Copy link
Member

cjw296 commented Aug 24, 2021

Oh, also feel free to upvote https://ideas.circleci.com/images/p/support-beta-and-rc-versions

cjw296 added a commit to cjw296/testfixtures that referenced this pull request Oct 12, 2021
tests: fix with Python 3.10 (changed exception messages)
cjw296 added a commit that referenced this pull request Oct 12, 2021
tests: fix with Python 3.10 (changed exception messages)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants