This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Url flipping #4
Merged
Url flipping #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 19, 2015 16:51
Refactored feature and features_by_name to build the contextual features; Cucumbers still pending.
| @@ -16,13 +20,17 @@ def disabled? | |||
| end | |||
|
|
|||
| def enable | |||
| @state = :enabled | |||
| persist | |||
| unless_overridden do | |||
There was a problem hiding this comment.
Why just not unless overridden? ? Looks like unnecessary method for me. For instance in line 8, you have if overridden?, which is almost the same.
There was a problem hiding this comment.
Good point. Fixed in 6e1890f
| @@ -16,6 +17,22 @@ module FlipFab | |||
| it 'assigns the context' do | |||
| expect(subject.context).to eq(context) | |||
| end | |||
|
|
|||
| context 'when the feature has been overriden' do | |||
|
signed-off-by: @tpaul09 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows features to be flipped and remain flipped based on URL parameters: https://trello.com/c/w3igufgx/143-5-ab-testing-feature-flipper
e.g.
http://localhost:3000?name_of_feature=enabled&name_of_other_feature=disabled@tpaul09 @kj-brown Could you please sign off?
@jennikate @sashatheb @martinbtt @calo81 @dragosmiron @dawid-sklodowski @sparrovv For reference